From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Shaun Kluzek <g0del@bigpond.com>
Cc: gregkh@suse.de, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB GADGET: u_serial.c: fixed a brace and whitespace coding style issue
Date: Thu, 01 Sep 2011 16:53:39 +0400 [thread overview]
Message-ID: <4E5F8053.4080603@ru.mvista.com> (raw)
In-Reply-To: <20110831072254.GA9706@epione>
Hello.
On 31-08-2011 11:22, Shaun Kluzek wrote:
> Signed-off-by: Shaun Kluzek<g0del@bigpond.com>
> ---
> drivers/usb/gadget/u_serial.c | 5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)
> diff --git a/drivers/usb/gadget/u_serial.c b/drivers/usb/gadget/u_serial.c
> index a8aa469..b86022f 100644
> --- a/drivers/usb/gadget/u_serial.c
> +++ b/drivers/usb/gadget/u_serial.c
> @@ -552,11 +552,8 @@ recycle:
> /* Push from tty to ldisc; without low_latency set this is handled by
> * a workqueue, so we won't get callbacks and can hold port_lock
> */
> - if (tty && do_push) {
> + if (tty && do_push)
> tty_flip_buffer_push(tty);
> - }
> -
What's wrong with the first empty line here?
> -
> /* We want our data queue to become empty ASAP, keeping data
> * in the tty and ldisc (not here). If we couldn't push any
> * this time around, there may be trouble unless there's an
WBR, Sergei
next prev parent reply other threads:[~2011-09-01 12:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-31 7:22 [PATCH] USB GADGET: u_serial.c: fixed a brace and whitespace coding style issue Shaun Kluzek
2011-09-01 12:53 ` Sergei Shtylyov [this message]
2011-09-18 8:26 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5F8053.4080603@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=g0del@bigpond.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox