From: Earl Chew <echew@ixiacom.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: <alan@lxorguk.ukuu.org.uk>, <viro@zeniv.linux.org.uk>,
<andi@firstfloor.org>, <oleg@redhat.com>
Subject: [ PATCH 1/1 ] coredump: use current->group_leader->comm instead of current->comm
Date: Thu, 1 Sep 2011 10:01:39 -0700 [thread overview]
Message-ID: <4E5FBA73.2050108@ixiacom.com> (raw)
Change corepattern %e and %E to use current->group_leader->comm instead of current->comm.
Multithreaded processes can use PR_SET_NAME (or the corresponding pthread_setname_np)
to configure the name of each thread.
A core dump can be triggered from any task in a group, and substituting current->comm
means that the name of the core file for a process can vary in surprising ways.
Using current->group_leader->comm makes the name of the core file more consistent
for a process when used with %e or %E.
Signed-off-by: Earl Chew <echew@ixiacom.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Oleg Nesterov <oleg@redhat.com>
--
--- fs/exec.c.orig 2011-08-28 21:16:01.000000000 -0700
+++ fs/exec.c 2011-09-01 09:58:42.032116998 -0700
@@ -1679,7 +1679,8 @@ static int cn_print_exe_file(struct core
exe_file = get_mm_exe_file(current->mm);
if (!exe_file) {
char *commstart = cn->corename + cn->used;
- ret = cn_printf(cn, "%s (path unknown)", current->comm);
+ ret = cn_printf(cn, "%s (path unknown)",
+ current->group_leader->comm);
cn_escape(commstart);
return ret;
}
@@ -1780,7 +1781,8 @@ static int format_corename(struct core_n
/* executable */
case 'e': {
char *commstart = cn->corename + cn->used;
- err = cn_printf(cn, "%s", current->comm);
+ err = cn_printf(cn, "%s",
+ current->group_leader->comm);
cn_escape(commstart);
break;
}
next reply other threads:[~2011-09-01 17:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 17:01 Earl Chew [this message]
2011-09-01 18:55 ` [ PATCH 1/1 ] coredump: use current->group_leader->comm instead of current->comm Alan Cox
2011-09-01 19:12 ` [PATCH 1/1 v2]: " Earl Chew
2011-09-02 16:30 ` Oleg Nesterov
2011-09-02 17:09 ` Earl Chew
2011-09-02 17:48 ` Oleg Nesterov
2011-09-02 23:05 ` Earl Chew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5FBA73.2050108@ixiacom.com \
--to=echew@ixiacom.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox