From: Earl Chew <echew@ixiacom.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"andi@firstfloor.org" <andi@firstfloor.org>,
"oleg@redhat.com" <oleg@redhat.com>
Subject: [PATCH 1/1 v2]: coredump: use current->group_leader->comm instead of current->comm
Date: Thu, 1 Sep 2011 12:12:55 -0700 [thread overview]
Message-ID: <4E5FD937.7050307@ixiacom.com> (raw)
In-Reply-To: <20110901195554.667c5e58@lxorguk.ukuu.org.uk>
> In your view, but there is a better way to do this - add a new case and
> letter for the behaviour you want. That way you don't break anyone elses
> defaults and expectation and people can set a corepattern dependant upon
> the group leader.
Ok.
The patterns %n or %N are the same as %e and %E except that they
use current->group_leader->comm instead of current->comm.
Signed-off-by: Earl Chew <echew@ixiacom.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Oleg Nesterov <oleg@redhat.com>
--
--- fs/exec.c.orig 2011-08-28 21:16:01.000000000 -0700
+++ fs/exec.c 2011-09-01 12:03:50.622059092 -0700
@@ -1670,7 +1670,7 @@ static void cn_escape(char *str)
*str = '!';
}
-static int cn_print_exe_file(struct core_name *cn)
+static int cn_print_exe_file(struct core_name *cn, const char *comm)
{
struct file *exe_file;
char *pathbuf, *path;
@@ -1679,7 +1679,7 @@ static int cn_print_exe_file(struct core
exe_file = get_mm_exe_file(current->mm);
if (!exe_file) {
char *commstart = cn->corename + cn->used;
- ret = cn_printf(cn, "%s (path unknown)", current->comm);
+ ret = cn_printf(cn, "%s (path unknown)", comm);
cn_escape(commstart);
return ret;
}
@@ -1777,6 +1777,18 @@ static int format_corename(struct core_n
cn_escape(namestart);
break;
}
+ /* task group executable */
+ case 'n': {
+ char *commstart = cn->corename + cn->used;
+ err = cn_printf(cn, "%s",
+ current->group_leader->comm);
+ cn_escape(commstart);
+ break;
+ }
+ case 'N':
+ err = cn_print_exe_file(cn,
+ current->group_leader->comm);
+ break;
/* executable */
case 'e': {
char *commstart = cn->corename + cn->used;
@@ -1785,7 +1797,7 @@ static int format_corename(struct core_n
break;
}
case 'E':
- err = cn_print_exe_file(cn);
+ err = cn_print_exe_file(cn, current->comm);
break;
/* core limit size */
case 'c':
next prev parent reply other threads:[~2011-09-01 19:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-01 17:01 [ PATCH 1/1 ] coredump: use current->group_leader->comm instead of current->comm Earl Chew
2011-09-01 18:55 ` Alan Cox
2011-09-01 19:12 ` Earl Chew [this message]
2011-09-02 16:30 ` [PATCH 1/1 v2]: " Oleg Nesterov
2011-09-02 17:09 ` Earl Chew
2011-09-02 17:48 ` Oleg Nesterov
2011-09-02 23:05 ` Earl Chew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5FD937.7050307@ixiacom.com \
--to=echew@ixiacom.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox