From: Jens Axboe <axboe@kernel.dk>
To: Maxim Patlasov <maxim.patlasov@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] cfq: queued/in_driver stats
Date: Fri, 02 Sep 2011 14:40:43 -0600 [thread overview]
Message-ID: <4E613F4B.8030502@kernel.dk> (raw)
In-Reply-To: <1314982962-30271-1-git-send-email-maxim.patlasov@gmail.com>
On 2011-09-02 11:02, Maxim Patlasov wrote:
> The patch implements gathering and exporting statistics for cfqd->rq_queued
> and cfqd->rq_in_driver. Average values of queued/in_driver are visible via
> /sys/.../iosched/queued_avg and /sys/.../iosched/in_driver_avg correspondingly.
> The output is in form of "%lu.%02lu %lu.%02lu %lu.%02lu" where the first
> value represents average over 1 sec interval, the second - over 5 sec,
> the third - over 15 sec.
>
> The patch also exports cfqd->hw_tag to be seen via /sys/.../iosched/hw_tag.
>
> Seeing hw_tag is useful to be sure that cfq detected NCQ correctly on given
> h/w. queued/in_driver stats are useful to debug performance problems: e.g.,
> if you know that fast h/w raid is able to concurrently process many requests
> quite effectively, but at the same time you observe high queued average and
> low in_driver one, you can suggest that cfq underloads h/w raid.
>
> Changes since first version: do_div was used wrongly, fixed.
Seems like an awful lot of code for something that could be gleaned
with blktrace?
--
Jens Axboe
next prev parent reply other threads:[~2011-09-02 20:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-02 17:02 [PATCH v2] cfq: queued/in_driver stats Maxim Patlasov
2011-09-02 20:40 ` Jens Axboe [this message]
2011-09-05 8:37 ` Maxim Patlasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E613F4B.8030502@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=maxim.patlasov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox