* regmap module_put usage.
@ 2011-09-05 12:55 Jonathan Cameron
2011-09-05 15:00 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Cameron @ 2011-09-05 12:55 UTC (permalink / raw)
To: Mark Brown; +Cc: LKML
Hi Mark,
I'm playing around with converting an IIO driver over to regmap
(to get a feel for when it makes sense and when it doesn't).
Right now, calling regmap_exit() results in a module_put of the
regmap-spi module which never has a module_get and hence it's
module use count wraps around and all hell breaks loose?
Am I missing something about where that get should occur?
It's entirely plausible I just have a local bug but I right
now I can't see how the logic is supposed to function!
Thanks,
Jonathan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: regmap module_put usage.
2011-09-05 12:55 regmap module_put usage Jonathan Cameron
@ 2011-09-05 15:00 ` Mark Brown
2011-09-05 15:13 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2011-09-05 15:00 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: LKML
On Mon, Sep 05, 2011 at 01:55:15PM +0100, Jonathan Cameron wrote:
> Right now, calling regmap_exit() results in a module_put of the
> regmap-spi module which never has a module_get and hence it's
> module use count wraps around and all hell breaks loose?
Oh, that's a bit of bitrot from a last minute reorg. I'll fix it.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: regmap module_put usage.
2011-09-05 15:00 ` Mark Brown
@ 2011-09-05 15:13 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2011-09-05 15:13 UTC (permalink / raw)
To: Mark Brown; +Cc: LKML
On 09/05/11 16:00, Mark Brown wrote:
> On Mon, Sep 05, 2011 at 01:55:15PM +0100, Jonathan Cameron wrote:
>
>> Right now, calling regmap_exit() results in a module_put of the
>> regmap-spi module which never has a module_get and hence it's
>> module use count wraps around and all hell breaks loose?
>
> Oh, that's a bit of bitrot from a last minute reorg. I'll fix it.
>
Thanks, I just scrapped the calls as any module will be dependent statically
on the relevant regmap-bus.c file anyway.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-05 15:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-05 12:55 regmap module_put usage Jonathan Cameron
2011-09-05 15:00 ` Mark Brown
2011-09-05 15:13 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox