public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Liam Girdwood <lrg@ti.com>, Graeme Gregory <gg@slimlogic.co.uk>,
	Samuel Oritz <sameo@linux.intel.com>
Subject: Re: [PATCH 3/6] regmap: Add the rbtree cache support
Date: Mon, 05 Sep 2011 18:15:49 +0200	[thread overview]
Message-ID: <4E64F5B5.9000903@metafoo.de> (raw)
In-Reply-To: <1315230662-12401-4-git-send-email-dp@opensource.wolfsonmicro.com>

On 09/05/2011 03:50 PM, Dimitris Papastamos wrote:
> [...]
> +
> +static int regcache_rbtree_init(struct regmap *map)
> +{
> +	struct regcache_rbtree_ctx *rbtree_ctx;
> +	int i;
> +	int ret;
> +
> +	map->cache = kmalloc(sizeof *rbtree_ctx, GFP_KERNEL);
> +	if (!map->cache)
> +		return -ENOMEM;
> +
> +	rbtree_ctx = map->cache;
> +	rbtree_ctx->root = RB_ROOT;
> +	rbtree_ctx->cached_rbnode = NULL;
> +
> +	for (i = 0; i < map->num_cache_defaults; i++) {
> +		ret = regcache_rbtree_write(map,
> +					    map->cache_defaults[ret].reg,
> +					    map->cache_defaults[ret].def);

map->cache_defaults[i]

> +		if (ret)
> +			goto err;
> +	}
> +
> +	return 0;
> +
> +err:
> +	regcache_exit(map);
> +	return ret;
> +}
> [...]

  reply	other threads:[~2011-09-05 16:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-05 13:50 [PATCH 0/6 v2] Introduce caching support for regmap Dimitris Papastamos
2011-09-05 13:50 ` [PATCH 1/6] regmap: Introduce caching support Dimitris Papastamos
2011-09-05 16:14   ` Lars-Peter Clausen
2011-09-05 13:50 ` [PATCH 2/6] regmap: Add the indexed cache support Dimitris Papastamos
2011-09-05 13:50 ` [PATCH 3/6] regmap: Add the rbtree " Dimitris Papastamos
2011-09-05 16:15   ` Lars-Peter Clausen [this message]
2011-09-05 13:51 ` [PATCH 4/6] regmap: Add the LZO " Dimitris Papastamos
2011-09-05 16:18   ` Lars-Peter Clausen
2011-09-15  9:35     ` Dimitris Papastamos
2011-09-05 13:51 ` [PATCH 5/6] regmap: Add the regcache_sync trace event Dimitris Papastamos
2011-09-05 13:51 ` [PATCH 6/6] regmap: Incorporate the regcache core into regmap Dimitris Papastamos
2011-09-05 16:22   ` Lars-Peter Clausen
2011-09-06  1:27     ` Mark Brown
2011-09-06  1:47 ` [PATCH 0/6 v2] Introduce caching support for regmap Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E64F5B5.9000903@metafoo.de \
    --to=lars@metafoo.de \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=dp@opensource.wolfsonmicro.com \
    --cc=gg@slimlogic.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox