From: Lars-Peter Clausen <lars@metafoo.de>
To: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@ti.com>, Graeme Gregory <gg@slimlogic.co.uk>,
Samuel Oritz <sameo@linux.intel.com>
Subject: Re: [PATCH 4/6] regmap: Add the LZO cache support
Date: Mon, 05 Sep 2011 18:18:30 +0200 [thread overview]
Message-ID: <4E64F656.3040009@metafoo.de> (raw)
In-Reply-To: <1315230662-12401-5-git-send-email-dp@opensource.wolfsonmicro.com>
On 09/05/2011 03:51 PM, Dimitris Papastamos wrote:
> This patch adds support for LZO compression when storing the register
> cache.
>
> For a typical device whose register map would normally occupy 25kB or 50kB
> by using the LZO compression technique, one can get down to ~5-7kB. There
> might be a performance penalty associated with each individual read/write
> due to decompressing/compressing the underlying cache, however that should not
> be noticeable. These memory benefits depend on whether the target architecture
> can get rid of the memory occupied by the original register defaults cache
> which is marked as __devinitconst. Nevertheless there will be some memory
> gain even if the target architecture can't get rid of the original register
> map, this should be around ~30-32kB instead of 50kB.
>
> Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
> ---
> drivers/base/regmap/Makefile | 2 +-
> drivers/base/regmap/internal.h | 2 +
> drivers/base/regmap/regcache-lzo.c | 361 ++++++++++++++++++++++++++++++++++++
> drivers/base/regmap/regcache.c | 1 +
> include/linux/regmap.h | 1 +
> 5 files changed, 366 insertions(+), 1 deletions(-)
> create mode 100644 drivers/base/regmap/regcache-lzo.c
>
Fails to compile due to CONFIG_LZO_{COMPRESS,DECOMPRESS} not being selected.
Also it will have issues, with caches where we don't use raw cache defaults.
next prev parent reply other threads:[~2011-09-05 16:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-05 13:50 [PATCH 0/6 v2] Introduce caching support for regmap Dimitris Papastamos
2011-09-05 13:50 ` [PATCH 1/6] regmap: Introduce caching support Dimitris Papastamos
2011-09-05 16:14 ` Lars-Peter Clausen
2011-09-05 13:50 ` [PATCH 2/6] regmap: Add the indexed cache support Dimitris Papastamos
2011-09-05 13:50 ` [PATCH 3/6] regmap: Add the rbtree " Dimitris Papastamos
2011-09-05 16:15 ` Lars-Peter Clausen
2011-09-05 13:51 ` [PATCH 4/6] regmap: Add the LZO " Dimitris Papastamos
2011-09-05 16:18 ` Lars-Peter Clausen [this message]
2011-09-15 9:35 ` Dimitris Papastamos
2011-09-05 13:51 ` [PATCH 5/6] regmap: Add the regcache_sync trace event Dimitris Papastamos
2011-09-05 13:51 ` [PATCH 6/6] regmap: Incorporate the regcache core into regmap Dimitris Papastamos
2011-09-05 16:22 ` Lars-Peter Clausen
2011-09-06 1:27 ` Mark Brown
2011-09-06 1:47 ` [PATCH 0/6 v2] Introduce caching support for regmap Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E64F656.3040009@metafoo.de \
--to=lars@metafoo.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dp@opensource.wolfsonmicro.com \
--cc=gg@slimlogic.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox