public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Zapolskiy <vz@mleia.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <peterz@infradead.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] sched: share task comm length value to userspace
Date: Mon, 05 Sep 2011 23:17:05 +0300	[thread overview]
Message-ID: <4E652E41.1030308@mleia.com> (raw)
In-Reply-To: <20110905124726.28b24db4@infradead.org>

On 05.09.2011 22:47, Arjan van de Ven wrote:
> On Mon,  5 Sep 2011 21:38:01 +0300
> Vladimir Zapolskiy<vz@mleia.com>  wrote:
>
>> This change allows to get a defined length of task comm in
>> userspace. For a moment this value is implied at least in two cases:
>> * max length of comm value got from /proc/$pid/stat
>> * max string length argument of prctl(PR_[SG]ET_NAME, ...)
>>
>> For these reasons it becomes desirable to impart task comm max length
>> value to userspace.
>
> I'm sorry but I don't like doing this.
>
> The moment we do this, we never can increase it anymore since userspace
> might be using it for its own uses and we'd break it if we changed
> this value.
Thanks for a comment. Your objections are quite clear, and I don't like 
this solution as well, but eventually having that value in userspace is 
really desirable. However in assumption that this value is preserved 
fixed and won't be changed in reasonable perspective, the presented 
approach becomes the most evident and simple.

>
> If we need to export this, we should export it in /proc or /sys
> somewhere as a dynamic value.....
>
Let's do it in a proper way. What's the common practice to export such 
limit values? I suppose via /proc/sys/kernel, please correct me, if I'm 
wrong.

--
With best wishes,
Vladimir

  reply	other threads:[~2011-09-05 20:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-05 18:38 [PATCH] sched: share task comm length value to userspace Vladimir Zapolskiy
2011-09-05 19:47 ` Arjan van de Ven
2011-09-05 20:17   ` Vladimir Zapolskiy [this message]
2011-09-05 20:39     ` Arjan van de Ven
2011-09-09 23:41       ` Andrew Morton
2011-09-09 23:49         ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E652E41.1030308@mleia.com \
    --to=vz@mleia.com \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox