From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
Ian Campbell <Ian.Campbell@eu.citrix.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH v3 2/2] xen: modify kernel mappings corresponding to granted pages
Date: Wed, 07 Sep 2011 12:05:18 -0700 [thread overview]
Message-ID: <4E67C06E.1030905@goop.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1109071825180.12963@kaball-desktop>
On 09/07/2011 10:38 AM, Stefano Stabellini wrote:
>
>> But also, this pattern of getting results back from batched calls is
>> unusual - actually, I think this is unique. If you have batched up a
>> map operation which has its map_op args allocated from the multicall
>> buffer, then the flush will implicitly free them as well, so it isn't
>> valid to read back from the structure later on. If you want to have an
>> args structure you can use once the hypercall has been issued, you need
>> to manually manage its lifetime.
> But I am not using the multicall buffer as argument, I am using the
> kmap_op passed to m2p_add_override.
Yep, I overlooked that.
J
next prev parent reply other threads:[~2011-09-07 19:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-07 16:38 [PATCH v3 0/2] xen: modify kernel mappings corresponding to granted pages Stefano Stabellini
2011-09-07 16:39 ` [PATCH v3 1/2] xen: add an "highmem" parameter to alloc_xenballooned_pages stefano.stabellini
2011-09-07 17:01 ` Jeremy Fitzhardinge
2011-09-08 12:46 ` Stefano Stabellini
2011-09-07 16:39 ` [PATCH v3 2/2] xen: modify kernel mappings corresponding to granted pages stefano.stabellini
2011-09-07 17:13 ` Jeremy Fitzhardinge
2011-09-07 17:38 ` Stefano Stabellini
2011-09-07 19:05 ` Jeremy Fitzhardinge [this message]
2011-09-07 22:27 ` Konrad Rzeszutek Wilk
2011-09-08 12:56 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E67C06E.1030905@goop.org \
--to=jeremy@goop.org \
--cc=Ian.Campbell@eu.citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox