[PATCH 1/2] leds-class: change back LEDS_CLASS to tristate instead of bool

[PATCH 1/2] leds-class: change back LEDS_CLASS to tristate instead of bool

[Bryan Wu]

LEDS_CLASS is required by leds and trigger drivers, but we can build it
as module. So change this option back as tristate and treak the help
message as well.

Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
---
 drivers/leds/Kconfig |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index b591e72..1c35927 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -17,10 +17,13 @@ menuconfig NEW_LEDS
 if NEW_LEDS
 
 config LEDS_CLASS
-	bool "LED Class Support"
+	tristate "LED Class Support"
 	help
 	  This option enables the led sysfs class in /sys/class/leds.  You'll
-	  need this to do anything useful with LEDs.  If unsure, say N.
+	  need this to do anything useful with LEDs.  If unsure, say M.
+
+	  Note: don't disable it as N, because plenty of led and trigger drivers
+	  are using this option.
 
 comment "LED drivers"
 
-- 
1.7.4.1

[PATCH 2/2] Documentation: leds-class: fix a typo

[Bryan Wu]

Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
---
 Documentation/leds/leds-class.txt |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/leds/leds-class.txt b/Documentation/leds/leds-class.txt
index 4996586..79699c2 100644
--- a/Documentation/leds/leds-class.txt
+++ b/Documentation/leds/leds-class.txt
@@ -61,8 +61,8 @@ Hardware accelerated blink of LEDs
 Some LEDs can be programmed to blink without any CPU interaction. To
 support this feature, a LED driver can optionally implement the
 blink_set() function (see <linux/leds.h>). To set an LED to blinking,
-however, it is better to use use the API function led_blink_set(),
-as it will check and implement software fallback if necessary.
+however, it is better to use the API function led_blink_set(), as it
+will check and implement software fallback if necessary.
 
 To turn off blinking again, use the API function led_brightness_set()
 as that will not just set the LED brightness but also stop any software
-- 
1.7.4.1

Re: [PATCH 1/2] leds-class: change back LEDS_CLASS to tristate instead of bool

[Richard Purdie]

On Tue, 2011-09-06 at 03:09 +0800, Bryan Wu wrote:
> LEDS_CLASS is required by leds and trigger drivers, but we can build it
> as module. So change this option back as tristate and treak the help
> message as well.
> 
> Signed-off-by: Bryan Wu <bryan.wu@canonical.com>

Acked-by: Richard Purdie <rchard.purdie@linuxfoundation.org>

> ---
>  drivers/leds/Kconfig |    7 +++++--
>  1 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index b591e72..1c35927 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -17,10 +17,13 @@ menuconfig NEW_LEDS
>  if NEW_LEDS
>  
>  config LEDS_CLASS
> -	bool "LED Class Support"
> +	tristate "LED Class Support"
>  	help
>  	  This option enables the led sysfs class in /sys/class/leds.  You'll
> -	  need this to do anything useful with LEDs.  If unsure, say N.
> +	  need this to do anything useful with LEDs.  If unsure, say M.
> +
> +	  Note: don't disable it as N, because plenty of led and trigger drivers
> +	  are using this option.
>  
>  comment "LED drivers"
>  

Re: [PATCH 2/2] Documentation: leds-class: fix a typo

[Richard Purdie]

On Tue, 2011-09-06 at 03:09 +0800, Bryan Wu wrote:
> Signed-off-by: Bryan Wu <bryan.wu@canonical.com>

Acked-by: Richard Purdie <rchard.purdie@linuxfoundation.org>

> ---
>  Documentation/leds/leds-class.txt |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/leds/leds-class.txt b/Documentation/leds/leds-class.txt
> index 4996586..79699c2 100644
> --- a/Documentation/leds/leds-class.txt
> +++ b/Documentation/leds/leds-class.txt
> @@ -61,8 +61,8 @@ Hardware accelerated blink of LEDs
>  Some LEDs can be programmed to blink without any CPU interaction. To
>  support this feature, a LED driver can optionally implement the
>  blink_set() function (see <linux/leds.h>). To set an LED to blinking,
> -however, it is better to use use the API function led_blink_set(),
> -as it will check and implement software fallback if necessary.
> +however, it is better to use the API function led_blink_set(), as it
> +will check and implement software fallback if necessary.
>  
>  To turn off blinking again, use the API function led_brightness_set()
>  as that will not just set the LED brightness but also stop any software

Re: [PATCH 1/2] leds-class: change back LEDS_CLASS to tristate instead of bool

[Bryan Wu]

On Tue, Sep 6, 2011 at 3:51 AM, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> On Tue, 2011-09-06 at 03:09 +0800, Bryan Wu wrote:
>> LEDS_CLASS is required by leds and trigger drivers, but we can build it
>> as module. So change this option back as tristate and treak the help
>> message as well.
>>
>> Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
>
> Acked-by: Richard Purdie <rchard.purdie@linuxfoundation.org>
>

Thanks a lot, Richard.

I also suggest we set LEDS_TRIGGERS as tristate, because it should be
a module when CONFIG_LEDS_CLASS=m.

-Bryan

Re: [PATCH 2/2] Documentation: leds-class: fix a typo

[Randy Dunlap]

On Mon, September 5, 2011 12:52 pm, Richard Purdie wrote:
> On Tue, 2011-09-06 at 03:09 +0800, Bryan Wu wrote:
>> Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
>
> Acked-by: Richard Purdie <rchard.purdie@linuxfoundation.org>

Who are we expecting to merge this patch?


>> ---
>>  Documentation/leds/leds-class.txt |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/leds/leds-class.txt
>> b/Documentation/leds/leds-class.txt
>> index 4996586..79699c2 100644
>> --- a/Documentation/leds/leds-class.txt
>> +++ b/Documentation/leds/leds-class.txt
>> @@ -61,8 +61,8 @@ Hardware accelerated blink of LEDs
>>  Some LEDs can be programmed to blink without any CPU interaction. To
>>  support this feature, a LED driver can optionally implement the
>>  blink_set() function (see <linux/leds.h>). To set an LED to blinking,
>> -however, it is better to use use the API function led_blink_set(),
>> -as it will check and implement software fallback if necessary.
>> +however, it is better to use the API function led_blink_set(), as it
>> +will check and implement software fallback if necessary.
>>
>>  To turn off blinking again, use the API function led_brightness_set()
>>  as that will not just set the LED brightness but also stop any software
>
>
> --


-- 
~Randy

Re: [PATCH 2/2] Documentation: leds-class: fix a typo

[Randy Dunlap]

On 09/05/11 12:52, Richard Purdie wrote:
> On Tue, 2011-09-06 at 03:09 +0800, Bryan Wu wrote:
>> Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
> 
> Acked-by: Richard Purdie <rchard.purdie@linuxfoundation.org>

Applied, thanks.

>> ---
>>  Documentation/leds/leds-class.txt |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/leds/leds-class.txt b/Documentation/leds/leds-class.txt
>> index 4996586..79699c2 100644
>> --- a/Documentation/leds/leds-class.txt
>> +++ b/Documentation/leds/leds-class.txt
>> @@ -61,8 +61,8 @@ Hardware accelerated blink of LEDs
>>  Some LEDs can be programmed to blink without any CPU interaction. To
>>  support this feature, a LED driver can optionally implement the
>>  blink_set() function (see <linux/leds.h>). To set an LED to blinking,
>> -however, it is better to use use the API function led_blink_set(),
>> -as it will check and implement software fallback if necessary.
>> +however, it is better to use the API function led_blink_set(), as it
>> +will check and implement software fallback if necessary.
>>  
>>  To turn off blinking again, use the API function led_brightness_set()
>>  as that will not just set the LED brightness but also stop any software


-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: [PATCH 1/2] leds-class: change back LEDS_CLASS to tristate instead of bool

[Russell King - ARM Linux]

On Mon, Sep 05, 2011 at 08:51:38PM +0100, Richard Purdie wrote:
> On Tue, 2011-09-06 at 03:09 +0800, Bryan Wu wrote:
> > LEDS_CLASS is required by leds and trigger drivers, but we can build it
> > as module. So change this option back as tristate and treak the help
> > message as well.
> > 
> > Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
> 
> Acked-by: Richard Purdie <rchard.purdie@linuxfoundation.org>
> 
> > ---
> >  drivers/leds/Kconfig |    7 +++++--
> >  1 files changed, 5 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> > index b591e72..1c35927 100644
> > --- a/drivers/leds/Kconfig
> > +++ b/drivers/leds/Kconfig
> > @@ -17,10 +17,13 @@ menuconfig NEW_LEDS
> >  if NEW_LEDS
> >  
> >  config LEDS_CLASS
> > -	bool "LED Class Support"
> > +	tristate "LED Class Support"
> >  	help
> >  	  This option enables the led sysfs class in /sys/class/leds.  You'll
> > -	  need this to do anything useful with LEDs.  If unsure, say N.
> > +	  need this to do anything useful with LEDs.  If unsure, say M.
> > +
> > +	  Note: don't disable it as N, because plenty of led and trigger drivers
> > +	  are using this option.

This is crap - putting a dependency in the help for an option is
unacceptable when we have things like randconfig etc which are
expected to work.

If this must be 'm' or 'y', then make it depend on m to force the
minimum setting.

Re: [PATCH 1/2] leds-class: change back LEDS_CLASS to tristate instead of bool

[Bryan Wu]

On Thu, Sep 29, 2011 at 4:07 PM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Mon, Sep 05, 2011 at 08:51:38PM +0100, Richard Purdie wrote:
>> On Tue, 2011-09-06 at 03:09 +0800, Bryan Wu wrote:
>> > LEDS_CLASS is required by leds and trigger drivers, but we can build it
>> > as module. So change this option back as tristate and treak the help
>> > message as well.
>> >
>> > Signed-off-by: Bryan Wu <bryan.wu@canonical.com>
>>
>> Acked-by: Richard Purdie <rchard.purdie@linuxfoundation.org>
>>
>> > ---
>> >  drivers/leds/Kconfig |    7 +++++--
>> >  1 files changed, 5 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
>> > index b591e72..1c35927 100644
>> > --- a/drivers/leds/Kconfig
>> > +++ b/drivers/leds/Kconfig
>> > @@ -17,10 +17,13 @@ menuconfig NEW_LEDS
>> >  if NEW_LEDS
>> >
>> >  config LEDS_CLASS
>> > -   bool "LED Class Support"
>> > +   tristate "LED Class Support"
>> >     help
>> >       This option enables the led sysfs class in /sys/class/leds.  You'll
>> > -     need this to do anything useful with LEDs.  If unsure, say N.
>> > +     need this to do anything useful with LEDs.  If unsure, say M.
>> > +
>> > +     Note: don't disable it as N, because plenty of led and trigger drivers
>> > +     are using this option.
>
> This is crap - putting a dependency in the help for an option is
> unacceptable when we have things like randconfig etc which are
> expected to work.
>
> If this must be 'm' or 'y', then make it depend on m to force the
> minimum setting.
>

I will remove the pointless help message and try to fix all compiling
error then, and send out the patch again.

Thanks,
-- 
Bryan Wu <bryan.wu@canonical.com>
Kernel Developer    +86.138-1617-6545 Mobile
Ubuntu Kernel Team
Canonical Ltd.      www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com