From: Jonathan Cameron <jic23@cam.ac.uk>
To: Greg KH <gregkh@suse.de>
Cc: Donggeun Kim <dg77.kim@samsung.com>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
akpm@linux-foundation.org, jic23@cam.ac.kr,
kyungmin.park@samsung.com
Subject: Re: [PATCH v2] misc: Add driver for GP2AP002 proximity/ambient light sensor
Date: Fri, 09 Sep 2011 10:16:24 +0100 [thread overview]
Message-ID: <4E69D968.2020100@cam.ac.uk> (raw)
In-Reply-To: <20110909083134.GA21835@suse.de>
On 09/09/11 09:31, Greg KH wrote:
> On Fri, Sep 09, 2011 at 05:22:26PM +0900, Donggeun Kim wrote:
>> SHARP GP2AP002 is proximity and ambient light sensor.
>> This patch supports it.
>>
>> Signed-off-by: Donggeun Kim <dg77.kim@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>> Changes for v2
>> - changed to expose lux
>> - changed request_irq to request_threaded_irq function
>> - added sysfs_notify function call
>
> Why? You should never do that unless you _really_ know what you are
> doing.
My bad. I suggested it was a better bet than doing a uevent to act
as a data ready notifier...
Greg, for future reference can you clarify why it's a bad idea or
give a reference (if it's been clarified elsewhere and I missed it!)
>
>
>> - cleaned up code
>>
>> Documentation/misc-devices/gp2ap002 | 44 +++
>> drivers/misc/Kconfig | 10 +
>> drivers/misc/Makefile | 1 +
>> drivers/misc/gp2ap002.c | 488 ++++++++++++++++++++++++++++++++
>> include/linux/platform_data/gp2ap002.h | 69 +++++
>
>
> Shouldn't this be an iio driver instead of some random misc driver with
> an undocumented sysfs file (hint, use Documentation/ABI for documenting
> stuff...) ?
Would certainly be welcome in IIO. We have a couple of similar sensors in there already.
I'm just aware some people/firms are really anti having
their drivers in staging (because the subsystem is there rather than because of issues
in the driver.
next prev parent reply other threads:[~2011-09-09 9:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-09 8:22 [PATCH v2] misc: Add driver for GP2AP002 proximity/ambient light sensor Donggeun Kim
2011-09-09 8:31 ` Greg KH
2011-09-09 9:16 ` Jonathan Cameron [this message]
2011-09-09 16:28 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E69D968.2020100@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=akpm@linux-foundation.org \
--cc=dg77.kim@samsung.com \
--cc=gregkh@suse.de \
--cc=jic23@cam.ac.kr \
--cc=kyungmin.park@samsung.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).