From: Nitin Gupta <ngupta@vflare.org>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Jerome Marchand <jmarchan@redhat.com>, Greg KH <greg@kroah.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Robert Jennings <rcj@linux.vnet.ibm.com>,
Linux Driver Project <devel@linuxdriverproject.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/5] Fix sparse warnings
Date: Fri, 09 Sep 2011 13:00:49 -0400 [thread overview]
Message-ID: <4E6A4641.9090606@vflare.org> (raw)
In-Reply-To: <CAHLZz10jm4Wewxe=MAVqcq22Zoe2aTAtgsOhx7Xdq0OUz_cwgA@mail.gmail.com>
On 09/08/2011 01:32 PM, Harvey Harrison wrote:
> On Thu, Sep 8, 2011 at 8:13 AM, Nitin Gupta <ngupta@vflare.org> wrote:
>> On 09/08/2011 04:17 AM, Jerome Marchand wrote:
>>
>> Since it just fixes couple of trivial sparse warnings,
>> I though no description is necessary? Anyways, here is
>> the description if needed for patch process:
>>
>> Fixed some sparse warnings by making zram_slot_free_notify()
>> static and max_zpage_size as size_t.
>>
>
> Please just paste the exact sparse warnings you fixed with this patch,
> then it will be more
> understandable _why_ you made the above changes.
>
new description:
Fixes sparse warning:
zram_drv.c:666:6: warning: symbol 'zram_slot_free_notify' was not
declared. Should it be static?
Also, max_zpage_size is now size_t just to be consistent with data-type
of other variables maintaining sizes of various kinds.
Thanks,
Nitin
next prev parent reply other threads:[~2011-09-09 17:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 1:29 [PATCH 0/5 v2] zram: minor features and cleanups Nitin Gupta
2011-09-08 1:29 ` [PATCH 1/5] Fix sparse warnings Nitin Gupta
2011-09-08 8:17 ` Jerome Marchand
2011-09-08 15:13 ` Nitin Gupta
2011-09-08 17:32 ` Harvey Harrison
2011-09-09 17:00 ` Nitin Gupta [this message]
2011-09-09 17:11 ` Dan Carpenter
2011-09-09 17:19 ` [PATCH 1/5 resend] " Nitin Gupta
2011-09-09 20:30 ` Greg KH
2011-09-08 1:29 ` [PATCH 2/5] Kernel config option for number of devices Nitin Gupta
2011-09-08 1:29 ` [PATCH 3/5] Make gobal variables use unique names Nitin Gupta
2011-09-08 1:29 ` [PATCH 4/5] Simplify zram disk resizing interface Nitin Gupta
2011-09-08 1:29 ` [PATCH 5/5] Set initial disksize to some default value Nitin Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E6A4641.9090606@vflare.org \
--to=ngupta@vflare.org \
--cc=devel@linuxdriverproject.org \
--cc=greg@kroah.com \
--cc=harvey.harrison@gmail.com \
--cc=jmarchan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=rcj@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox