From: Nitin Gupta <ngupta@vflare.org>
To: Valdis.Kletnieks@vt.edu
Cc: Greg KH <greg@kroah.com>, Jerome Marchand <jmarchan@redhat.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Robert Jennings <rcj@linux.vnet.ibm.com>,
Linux Driver Project <devel@linuxdriverproject.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/5] zram: Set initial disksize to some default value
Date: Fri, 09 Sep 2011 22:04:34 -0400 [thread overview]
Message-ID: <4E6AC5B2.40703@vflare.org> (raw)
In-Reply-To: <62714.1315615809@turing-police.cc.vt.edu>
On 09/09/2011 08:50 PM, Valdis.Kletnieks@vt.edu wrote:
> On Fri, 09 Sep 2011 20:18:56 EDT, Nitin Gupta said:
>> On 09/09/2011 07:12 PM, Greg KH wrote:
>>
>>> On Fri, Sep 09, 2011 at 07:01:04PM -0400, Nitin Gupta wrote:
>>>> Currently, we set initial disksize as 0, which forces
>>>> user to write some value to corresponding zram device's
>>>> sysfs node, before the device can be used. Now, we avoid
>>>> this step by providing some default size initially.
>>>>
>>>> To change the disksize, user must:
>>>> - Reset disk.
>>>> Ex: echo 1 > /sys/block/zram0/reset
>>>> (NOTE: disksize is set to the default value after reset)
>>>>
>>>> - Set new disksize.
>>>> Ex: echo $((256*1024*1024)) > /sys/block/zram0/disksize
>>>
>>> So, what tools just broke with this change?
>>>
>>> And where is the sysfs file documentation change that should go along
>>> with this?
>>>
>>
>>
>> This change does not change any sysfs names or behavior, so does not
>> break any scripts that assume the current behavior.
>
> Consider the current case: We init size to zero, and a startup script changes
> it to 1024 and then sticks 768 of data in there. No Problem.
>
> We now get a kernel that's built with a default of 512. The startup script
> tries to change it to 1024, but doesn't know it has to splat something into
> 'reset' for it to actually work. It then tries to stick 768 of data in there,
> and hilarity ensues...
>
> If I haven't misunderstood...
>
Setting default size of say 512 doesn't make the device initialized.
The initialization happens only when user issues any I/O to the device
and only after initialization the disksize cannot be changed.
So, when user writes say 768 as new disksize in uninitialized state, the
new disksize will take effect and there will be no surprises.
Device reset is needed only when user wants to discard existing data and
bring device to uninitialized state again, after which disksize can be
changed again.
Nitin
prev parent reply other threads:[~2011-09-10 2:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-09 23:00 [PATCH 0/5 v3] zram: minor cleanups and features Nitin Gupta
2011-09-09 23:01 ` [PATCH 1/5] zram: Fix sparse warnings Nitin Gupta
2011-09-09 23:01 ` [PATCH 2/5] zram: Kernel config option for number of devices Nitin Gupta
2011-09-09 23:09 ` Greg KH
2011-09-10 2:15 ` Nitin Gupta
2011-09-09 23:01 ` [PATCH 3/5] zram: Make gobal variables use unique names Nitin Gupta
2011-09-09 23:10 ` Greg KH
2011-09-10 0:35 ` Nitin Gupta
2011-09-10 0:45 ` Greg KH
2011-09-09 23:01 ` [PATCH 4/5] zram: Simplify zram disk resizing interface Nitin Gupta
2011-09-09 23:11 ` Greg KH
2011-09-10 0:12 ` Nitin Gupta
2011-09-10 0:41 ` Greg KH
2011-09-09 23:01 ` [PATCH 5/5] zram: Set initial disksize to some default value Nitin Gupta
2011-09-09 23:12 ` Greg KH
2011-09-10 0:18 ` Nitin Gupta
2011-09-10 0:42 ` Greg KH
2011-09-10 14:51 ` Nitin Gupta
2011-09-10 0:50 ` Valdis.Kletnieks
2011-09-10 2:04 ` Nitin Gupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E6AC5B2.40703@vflare.org \
--to=ngupta@vflare.org \
--cc=Valdis.Kletnieks@vt.edu \
--cc=devel@linuxdriverproject.org \
--cc=greg@kroah.com \
--cc=jmarchan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=rcj@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox