From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
x86@kernel.org, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, namhyung@gmail.com, jolsa@redhat.com,
yrl.pp-manager.tt@hitachi.com
Subject: Re: [PATCH] arch/x86/kernel/kprobes.c: quiet sprase noise about external linkage
Date: Sat, 10 Sep 2011 17:43:01 +0900 [thread overview]
Message-ID: <4E6B2315.8000202@hitachi.com> (raw)
In-Reply-To: <201109091559.58280.hartleys@visionengravers.com>
(2011/09/10 7:59), H Hartley Sweeten wrote:
> The function arch_unoptimize_kprobes is already declared extern in
> <linux/kprobes.h>. The actual function should not be marked as extern.
> This quiets the following sparse noise:
>
> warning: function 'arch_unoptimize_kprobes' with external linkage has definition
Right, there is no reason to mark it extern.
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Thank you,
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> Cc: Namhyung Kim <namhyung@gmail.com>
> Cc: Jiri Olsa <jolsa@redhat.com>
>
> ---
>
> diff --git a/arch/x86/kernel/kprobes.c b/arch/x86/kernel/kprobes.c
> index f1a6244..e8d5903 100644
> --- a/arch/x86/kernel/kprobes.c
> +++ b/arch/x86/kernel/kprobes.c
> @@ -1483,8 +1483,8 @@ static void __kprobes setup_unoptimize_kprobe(struct text_poke_param *tprm,
> * Recover original instructions and breakpoints from relative jumps.
> * Caller must call with locking kprobe_mutex.
> */
> -extern void arch_unoptimize_kprobes(struct list_head *oplist,
> - struct list_head *done_list)
> +void arch_unoptimize_kprobes(struct list_head *oplist,
> + struct list_head *done_list)
> {
> struct optimized_kprobe *op, *tmp;
> int c = 0;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com
prev parent reply other threads:[~2011-09-10 8:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-09 22:59 [PATCH] arch/x86/kernel/kprobes.c: quiet sprase noise about external linkage H Hartley Sweeten
2011-09-10 8:43 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E6B2315.8000202@hitachi.com \
--to=masami.hiramatsu.pt@hitachi.com \
--cc=hartleys@visionengravers.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yrl.pp-manager.tt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox