From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760036Ab1IKKgJ (ORCPT ); Sun, 11 Sep 2011 06:36:09 -0400 Received: from mail.free-electrons.com ([88.190.12.23]:59457 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754020Ab1IKKgH (ORCPT ); Sun, 11 Sep 2011 06:36:07 -0400 Message-ID: <4E6C8F09.4060806@free-electrons.com> Date: Sun, 11 Sep 2011 12:35:53 +0200 From: David Wagner User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.15) Gecko/20110402 Icedove/3.1.9 MIME-Version: 1.0 To: dedekind1@gmail.com CC: Arnd Bergmann , linux-mtd , linux-embedded , lkml , Tim Bird , David Woodhouse Subject: Re: [PATCHv3] UBI: new module ubiblk: block layer on top of UBI References: <1308922482-14967-1-git-send-email-david.wagner@free-electrons.com> <1315280704.19067.14.camel@sauron> <1315282208.19067.24.camel@sauron> <201109081726.00769.arnd@arndb.de> <1315569206.7905.41.camel@sauron> <4E6A25B1.8070400@free-electrons.com> <1315736297.18731.1.camel@sauron> In-Reply-To: <1315736297.18731.1.camel@sauron> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/09/2011 12:18, Artem Bityutskiy wrote: > On Fri, 2011-09-09 at 16:41 +0200, David Wagner wrote: >>> 1. Stick with the own cdev approach - the driver becomes very simple >>> in this case - we review it. >> >> This is the way it's implemented in v4, right ? > > Yes, but I though I sent you some feed back with minor things as well as > with major issue related to race condigions: you should keep the UBI > volume open as long as your block device is referenced, to prevent the > UBI volume from being removed. > Ah, yes, of course. I made these changes and will send them monday. Regards, David.