From: "Pádraig Brady" <P@draigBrady.com>
To: Greg Lee <glee@swspec.com>
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add WDIOC_GETTIMELEFT ioctl support to w83627 watchdog driver
Date: Mon, 12 Sep 2011 10:05:43 +0100 [thread overview]
Message-ID: <4E6DCB67.1060105@draigBrady.com> (raw)
In-Reply-To: <CADB-PD0N+tEC0H_iKzvV4Ms2snAJ3-+Lnk7tNF5=egAHdVuARQ@mail.gmail.com>
On 09/12/2011 06:10 AM, Greg Lee wrote:
> Add WDIOC_GETTIMELEFT ioctl allowing you to check how much time is left
> on the watchdog counter before a reset occurs.
>
> Signed-off-by: Greg Lee <glee [at] swspec.com>
>
> ---
> --- linux-3.1-rc5.orig/drivers/watchdog/w83627hf_wdt.c
> +++ linux-3.1-rc5.mine/drivers/watchdog/w83627hf_wdt.c
> @@ -176,6 +176,23 @@ static int wdt_set_heartbeat(int t)
> return 0;
> }
>
> +static int wdt_get_time_left(void){
Thanks for this.
Please put the { on the next line.
s/wdt_ctrl/wdt_set_time/
s/wdt_get_time_left/wdt_get_time/
cheers,
Pádraig.
prev parent reply other threads:[~2011-09-12 9:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-12 5:10 [PATCH] Add WDIOC_GETTIMELEFT ioctl support to w83627 watchdog driver Greg Lee
2011-09-12 9:05 ` Pádraig Brady [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E6DCB67.1060105@draigBrady.com \
--to=p@draigbrady.com \
--cc=glee@swspec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox