Re: [PATCH] per-cgroup tcp buffer limitation

Eric Dumazet
2011-09-07T02:39:01Z

Le mardi 06 septembre 2011 à 15:12 -0700, Greg Thelen a écrit :

> >>> +#define sk_sockets_allocated(sk) \
> >>> +({ \
> >>> + struct percpu_counter *__p; \
> >>> + __p = (sk)->sk_prot->sockets_allocated(sk->sk_cgrp); \
> >>> + __p; \
> >>> +})
>
> Could this be simplified as (same applies to following few macros):
>
> static inline struct percpu_counter *sk_sockets_allocated(struct sock *sk)
> {
> return sk->sk_prot->sockets_allocated(sk->sk_cgrp);
> }
>

Please Greg, dont copy/paste huge sequence of code if you dont have
anymore comments.

Right before sending your mail, remove all parts that we already got in
previous mails.

Thanks