From: "canquan.shen" <shencanquan@huawei.com>
To: len.brown@intel.com
Cc: Bjorn Helgaas <bhelgaas@google.com>,
"shemminger@vyatta.com" <shemminger@vyatta.com>,
"yakui.zhao@intel.com" <yakui.zhao@intel.com>,
"xiaowei.yang@huawei.com" <xiaowei.yang@huawei.com>,
hanweidong <hanweidong@huawei.com>,
linqiangmin@huawei.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: Re: [PATCH v2] acpi: Fix CPU hot removal problem
Date: Tue, 13 Sep 2011 13:58:03 +0800 [thread overview]
Message-ID: <4E6EF0EB.2040701@huawei.com> (raw)
In-Reply-To: <4E682AC8.7040302@huawei.com>
On 2011/9/8 10:39, canquan.shen wrote:
> We run Linux as a guest in Xen environment. When used xen tools
> (xm vcpu-set <n>) to hot add and remove vcpu to and from the guest,
> we encountered the failure on vcpu removal. We found the reason is
> that it didn't go to really remove cpu in the cpu removal code path.
>
> This patch adds acpi_bus_trim in acpi_process_hotplug_notify to fix
> this issue. With this patch, it works fine for us.
>
> Signed-off-by: Canquan Shen <shencanquan@huawei.com>
> ---
> drivers/acpi/processor_driver.c | 5 +++++
> 1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/acpi/processor_driver.c
> b/drivers/acpi/processor_driver.c
> index a1c564f..114592f 100644
> --- a/drivers/acpi/processor_driver.c
> +++ b/drivers/acpi/processor_driver.c
> @@ -678,7 +678,11 @@ static void
> acpi_processor_hotplug_notify(acpi_handle handle,
> return;
> }
>
> + if (acpi_bus_trim(device, 1)) {
> + printk(KERN_ERR PREFIX
> + "Removing device failed\n");
> + return;
> + }
> break;
> default:
> ACPI_DEBUG_PRINT((ACPI_DB_INFO,
Hi Len,
I just see your email in linux-kernel maillist and known that your
kernel.org email is kaput, so I resend this email to your intel email
address.
Thanks,
- Canquan Shen
next prev parent reply other threads:[~2011-09-13 5:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 2:39 [PATCH v2] acpi: Fix CPU hot removal problem canquan.shen
2011-09-13 5:58 ` canquan.shen [this message]
2011-09-13 15:49 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E6EF0EB.2040701@huawei.com \
--to=shencanquan@huawei.com \
--cc=bhelgaas@google.com \
--cc=hanweidong@huawei.com \
--cc=len.brown@intel.com \
--cc=linqiangmin@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=xiaowei.yang@huawei.com \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox