From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754417Ab1IMF6Q (ORCPT ); Tue, 13 Sep 2011 01:58:16 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:62324 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752920Ab1IMF6P (ORCPT ); Tue, 13 Sep 2011 01:58:15 -0400 Date: Tue, 13 Sep 2011 13:58:03 +0800 From: "canquan.shen" Subject: Re: [PATCH v2] acpi: Fix CPU hot removal problem In-reply-to: <4E682AC8.7040302@huawei.com> X-Originating-IP: [10.166.80.130] To: len.brown@intel.com Cc: Bjorn Helgaas , "shemminger@vyatta.com" , "yakui.zhao@intel.com" , "xiaowei.yang@huawei.com" , hanweidong , linqiangmin@huawei.com, "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" Message-id: <4E6EF0EB.2040701@huawei.com> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7BIT User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:6.0.2) Gecko/20110902 Thunderbird/6.0.2 X-CFilter-Loop: Reflected References: <4E682AC8.7040302@huawei.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2011/9/8 10:39, canquan.shen wrote: > We run Linux as a guest in Xen environment. When used xen tools > (xm vcpu-set ) to hot add and remove vcpu to and from the guest, > we encountered the failure on vcpu removal. We found the reason is > that it didn't go to really remove cpu in the cpu removal code path. > > This patch adds acpi_bus_trim in acpi_process_hotplug_notify to fix > this issue. With this patch, it works fine for us. > > Signed-off-by: Canquan Shen > --- > drivers/acpi/processor_driver.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/drivers/acpi/processor_driver.c > b/drivers/acpi/processor_driver.c > index a1c564f..114592f 100644 > --- a/drivers/acpi/processor_driver.c > +++ b/drivers/acpi/processor_driver.c > @@ -678,7 +678,11 @@ static void > acpi_processor_hotplug_notify(acpi_handle handle, > return; > } > > + if (acpi_bus_trim(device, 1)) { > + printk(KERN_ERR PREFIX > + "Removing device failed\n"); > + return; > + } > break; > default: > ACPI_DEBUG_PRINT((ACPI_DB_INFO, Hi Len, I just see your email in linux-kernel maillist and known that your kernel.org email is kaput, so I resend this email to your intel email address. Thanks, - Canquan Shen