public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "canquan.shen" <shencanquan@huawei.com>
To: len.brown@intel.com
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	"shemminger@vyatta.com" <shemminger@vyatta.com>,
	"yakui.zhao@intel.com" <yakui.zhao@intel.com>,
	"xiaowei.yang@huawei.com" <xiaowei.yang@huawei.com>,
	hanweidong <hanweidong@huawei.com>,
	linqiangmin@huawei.com,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: [PATCH v3] acpi: Fix CPU hot removal problem
Date: Wed, 14 Sep 2011 10:18:02 +0800	[thread overview]
Message-ID: <4E700EDA.7090505@huawei.com> (raw)

We run linux as a guest in Xen environment. When we used the xen tools
(xm vcpu-set <n>) to hot add and remove vcpu to and from the guest, we
encountered the failure on vcpu removal. We found the reason is that it
didn't go to really remove cpu in the cpu removal code path.

This patch adds acpi_bus_trim in acpi_process_hotplug_notify to fix this
issue. With this patch, it works fine for us.

Signed-off-by: Shen canquan <shencanquan@huawei.com>
---
  drivers/acpi/processor_driver.c |    7 +++++++
  1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/drivers/acpi/processor_driver.c 
b/drivers/acpi/processor_driver.c
index a4e0f1b..0856ef8 100644
--- a/drivers/acpi/processor_driver.c
+++ b/drivers/acpi/processor_driver.c
@@ -677,6 +677,13 @@ static void 
acpi_processor_hotplug_notify(acpi_handle handle,
  				    "Driver data is NULL, dropping EJECT\n");
  			return;
  		}
+		ACPI_DEBUG_PRINT((ACPI_DB_INFO,
+			"Hot-removing processor device %s\n",
+			dev_name(&device->dev)));
+		if (acpi_bus_trim(device, 1)) {
+			printk(KERN_ERR "ACPI: Removing device failed!\n");
+			return;
+		}
  		break;
  	default:
  		ACPI_DEBUG_PRINT((ACPI_DB_INFO,
-- 
1.7.6.0


             reply	other threads:[~2011-09-14  2:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-14  2:18 canquan.shen [this message]
2011-09-14 14:14 ` [PATCH v3] acpi: Fix CPU hot removal problem Bjorn Helgaas
2011-09-15  1:35   ` canquan.shen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E700EDA.7090505@huawei.com \
    --to=shencanquan@huawei.com \
    --cc=bhelgaas@google.com \
    --cc=hanweidong@huawei.com \
    --cc=len.brown@intel.com \
    --cc=linqiangmin@huawei.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    --cc=xiaowei.yang@huawei.com \
    --cc=yakui.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox