From: Tao Ma <tm@tao.ma>
To: Jens Axboe <jaxboe@fusionio.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Shaohua Li <shli@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND] block: Don't check QUEUE_FLAG_SAME_COMP in __blk_complete_request.
Date: Thu, 15 Sep 2011 22:48:19 +0800 [thread overview]
Message-ID: <4E721033.8060201@tao.ma> (raw)
In-Reply-To: <4E71E15F.1050507@fusionio.com>
On 09/15/2011 07:28 PM, Jens Axboe wrote:
> On 2011-09-15 13:17, Christoph Hellwig wrote:
>> On Thu, Sep 15, 2011 at 10:16:02AM +0800, Tao Ma wrote:
>>>> why not delete bio_set_completion_cpu()?
>>> Not sure. It is added in commit c7c22e4d from the very beginning, and in
>>> the commit log Jens described it as:
>>> A bio helper (bio_set_completion_cpu()) is also added, so that queuers
>>> can ask for completion on that specific CPU. Maybe it is obsolete.
>>> Anyway, I am fine to generate a patch to remove it if you prefer.
>>>> 1. nobody uses it in my search
>>> yes, but it may be designed for someone to use it. The same goes with
>>> BIO_CPU_AFFINE.
>>
>> This code is unused, and from the all the discussions lately pretty
>> obviously broken. The only thing keeping it serves is creating more
>> confusion and possibly more bugs.
>
> We can kill bio_set_completion_cpu(). I'm fine with leaving cpu control
> to the request based drivers, they are the only ones that can toggle the
> setting anyway.
So we should remove bio_comp_cpu and BIO_CPU_AFFINE also if we have
decided to only leave cpu control to the request based drivers, right?
I will generate a patch for it later.
Thanks
Tao
next prev parent reply other threads:[~2011-09-15 14:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-14 7:23 [PATCH RESEND] block: warn if tag is greater than real_max_depth Tao Ma
2011-09-14 7:23 ` [PATCH RESEND] block: Don't check QUEUE_FLAG_SAME_COMP in __blk_complete_request Tao Ma
2011-09-15 1:05 ` Shaohua Li
2011-09-15 2:16 ` Tao Ma
2011-09-15 11:17 ` Christoph Hellwig
2011-09-15 11:28 ` Jens Axboe
2011-09-15 14:48 ` Tao Ma [this message]
2011-10-24 15:03 ` [PATCH RESEND] block: warn if tag is greater than real_max_depth Tao Ma
2011-10-25 8:19 ` Jens Axboe
2011-12-20 0:07 ` Dan Williams
2011-12-20 1:11 ` Tao Ma
2011-12-20 1:45 ` Dan Williams
2011-12-20 13:56 ` Jens Axboe
2011-12-20 15:21 ` Tao Ma
2011-12-20 15:58 ` [PATCH] block: warn the wrong tag only if it " Tao Ma
2011-12-20 17:31 ` Williams, Dan J
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E721033.8060201@tao.ma \
--to=tm@tao.ma \
--cc=hch@infradead.org \
--cc=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).