From: Paul Turner <pjt@google.com>
To: Wang Xingchao <xingchao.wang@intel.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu,
peterz@infradead.org, yong.zhang0@gmail.com, alex.shi@intel.com
Subject: Re: [PATCH] cfs: NULL pointer check
Date: Fri, 16 Sep 2011 00:42:41 -0700 [thread overview]
Message-ID: <4E72FDF1.3080608@google.com> (raw)
In-Reply-To: <1316195333-12374-1-git-send-email-xingchao.wang@intel.com>
On 09/16/11 10:48, Wang Xingchao wrote:
> se maybe NULL if cfs_rq->rb_leftmost is NULL
nack, it had better not be; otherwise we've got a corrupt tree!
Also, this diff is against the previous -- please bundle dependent
patches as a series in the future.
Thanks,
- Paul
>
> Signed-off-by: Wang Xingchao<xingchao.wang@intel.com>
> ---
> kernel/sched_fair.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c
> index fef0bfd..109b232 100644
> --- a/kernel/sched_fair.c
> +++ b/kernel/sched_fair.c
> @@ -1130,6 +1130,10 @@ check_preempt_tick(struct cfs_rq *cfs_rq, struct sched_entity *curr)
> return;
>
> se = __pick_first_entity(cfs_rq);
> +
> + if (!se)
> + return;
> +
> delta = curr->vruntime - se->vruntime;
>
> if (delta< 0)
next prev parent reply other threads:[~2011-09-16 7:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-16 17:48 [PATCH] cfs: NULL pointer check Wang Xingchao
2011-09-16 5:57 ` Yong Zhang
2011-09-16 7:42 ` Paul Turner [this message]
2011-09-16 21:18 ` xingchao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E72FDF1.3080608@google.com \
--to=pjt@google.com \
--cc=alex.shi@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=xingchao.wang@intel.com \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox