RE: [PATCH v2 0/3] staging: zcache: xcfmalloc support

Dave Hansen
2011-10-03T16:02:16Z

Hi Dan/Nitin,

I've been reading through Seth's patches a bit and looking over the
locking in general. I'm wondering why preempt_disable() is used so
heavily. Preempt seems to be disabled for virtually all of zcache's
operations. It seems a bit unorthodox, and I guess I'm anticipating the
future screams of the low-latency folks. :)

I think long-term it will hurt zcache's ability to move in to other
code. Right now, it's pretty limited to being used in conjunction with
memory reclaim called from kswapd. Seems like something we ought to add
to the TODO list before it escapes from staging/.

-- Dave