public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nitin Gupta <ngupta@vflare.org>
To: Seth Jennings <sjenning@linux.vnet.ibm.com>
Cc: Greg KH <greg@kroah.com>,
	gregkh@suse.de, devel@driverdev.osuosl.org,
	dan.magenheimer@oracle.com, cascardo@holoscopio.com,
	linux-kernel@vger.kernel.org, dave@linux.vnet.ibm.com,
	linux-mm@kvack.org, brking@linux.vnet.ibm.com,
	rcj@linux.vnet.ibm.com
Subject: Re: [PATCH v2 0/3] staging: zcache: xcfmalloc support
Date: Fri, 16 Sep 2011 13:46:41 -0400	[thread overview]
Message-ID: <4E738B81.2070005@vflare.org> (raw)
In-Reply-To: <4E72284B.2040907@linux.vnet.ibm.com>

Hi Seth,

On 09/15/2011 12:31 PM, Seth Jennings wrote:

> 
> So this is how I see things...
> 
> Right now xvmalloc is broken for zcache's application because
> of its huge fragmentation for half the valid allocation sizes
> (> PAGE_SIZE/2).
> 
> My xcfmalloc patches are _a_ solution that is ready now.  Sure,
> it doesn't so compaction yet, and it has some metadata overhead.
> So it's not "ideal" (if there is such I thing). But it does fix
> the brokenness of xvmalloc for zcache's application.
> 
> So I see two ways going forward:
> 
> 1) We review and integrate xcfmalloc now.  Then, when you are
> done with your allocator, we can run them side by side and see
> which is better by numbers.  If yours is better, you'll get no
> argument from me and we can replace xcfmalloc with yours.
> 
> 2) We can agree on a date (sooner rather than later) by which your
> allocator will be completed.  At that time we can compare them and
> integrate the best one by the numbers.
> 


I think replacing allocator every few weeks isn't a good idea. So, I
guess better would be to let me work for about 2 weeks and try the slab
based approach.  If nothing works out in this time, then maybe xcfmalloc
can be integrated after further testing.

Thanks,
Nitin

  parent reply	other threads:[~2011-09-16 17:46 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-07 14:09 [PATCH v2 0/3] staging: zcache: xcfmalloc support Seth Jennings
2011-09-07 14:09 ` [PATCH v2 1/3] staging: zcache: xcfmalloc memory allocator for zcache Seth Jennings
2011-09-07 14:09 ` [PATCH v2 2/3] staging: zcache: replace xvmalloc with xcfmalloc Seth Jennings
2011-09-07 14:09 ` [PATCH v2 3/3] staging: zcache: add zv_page_count and zv_desc_count Seth Jennings
2011-09-09 20:34 ` [PATCH v2 0/3] staging: zcache: xcfmalloc support Greg KH
2011-09-10  2:41   ` Nitin Gupta
2011-09-12 14:35     ` Seth Jennings
2011-09-13  1:55       ` Nitin Gupta
2011-09-13 15:58         ` Seth Jennings
2011-09-13 21:18           ` Nitin Gupta
2011-09-15 16:31             ` Seth Jennings
2011-09-15 17:29               ` Dan Magenheimer
2011-09-15 19:24                 ` Seth Jennings
2011-09-15 20:07                   ` Dan Magenheimer
2011-10-03 15:59                     ` Dave Hansen
2011-10-03 17:54                       ` Nitin Gupta
2011-10-03 18:22                         ` Dave Hansen
2011-10-05  1:03                           ` Dan Magenheimer
2011-09-15 22:17                   ` Dave Hansen
2011-09-15 22:27                     ` Dan Magenheimer
2011-09-16 17:36                     ` Nitin Gupta
2011-09-16 17:52                   ` Nitin Gupta
2011-09-16 17:46               ` Nitin Gupta [this message]
2011-09-16 18:33                 ` Seth Jennings
2011-11-01 17:30                 ` Dave Hansen
2011-11-01 18:35                   ` Dan Magenheimer
2011-11-02  2:42                     ` Nitin Gupta
2011-09-29 17:47 ` Seth Jennings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E738B81.2070005@vflare.org \
    --to=ngupta@vflare.org \
    --cc=brking@linux.vnet.ibm.com \
    --cc=cascardo@holoscopio.com \
    --cc=dan.magenheimer@oracle.com \
    --cc=dave@linux.vnet.ibm.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rcj@linux.vnet.ibm.com \
    --cc=sjenning@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox