From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754928Ab1ISN2o (ORCPT ); Mon, 19 Sep 2011 09:28:44 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:35900 "EHLO e7.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752698Ab1ISN2n (ORCPT ); Mon, 19 Sep 2011 09:28:43 -0400 Message-ID: <4E774377.8030703@us.ibm.com> Date: Mon, 19 Sep 2011 08:28:23 -0500 From: Anthony Liguori User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110516 Lightning/1.0b2 Thunderbird/3.1.10 MIME-Version: 1.0 To: Rusty Russell CC: Pawel Moll , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, "Michael S.Tsirkin" Subject: Re: [RFC v3] arm: Add platform bus driver for memory mapped virtio device References: <1316191623-3835-1-git-send-email-pawel.moll@arm.com> <4E7380FD.1030200@us.ibm.com> <874o09ryzm.fsf@rustcorp.com.au> In-Reply-To: <874o09ryzm.fsf@rustcorp.com.au> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/18/2011 10:29 PM, Rusty Russell wrote: > On Fri, 16 Sep 2011 12:01:49 -0500, Anthony Liguori wrote: >> On 09/16/2011 11:47 AM, Pawel Moll wrote: >>> This patch, based on virtio PCI driver, adds support for memory >>> mapped (platform) virtio device. This should allow environments >>> like qemu to use virtio-based block& network devices. >>> >>> One can define and register a platform device which resources >>> will describe memory mapped control registers and "mailbox" >>> interrupt. Such device can be also instantiated using the Device >>> Tree node with compatible property equal "virtio,mmio". >>> >>> Cc: Rusty Russell >>> Cc: Anthony Liguori >>> Cc: Michael S.Tsirkin >>> Signed-off-by: Pawel Moll >> >> Have you written a specification for this device? >> >> Rusty maintains a formal spec for all virtio devices at: >> >> http://ozlabs.org/~rusty/virtio-spec/ >> >> The spec should be written before merging the code to make sure that there >> aren't future compatibility problems. > > A good idea, but the current spec is for PCI. I wonder if we should > move the PCI part out to an appendix and make it more general? > > Meanwhile, perhaps this would be suitable as an appendix. I was thinking an appendix would be a good start. Regards, Anthony Liguori > > Cheers, > Rusty.