From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932572Ab1ISShs (ORCPT <rfc822;w@1wt.eu>);
	Mon, 19 Sep 2011 14:37:48 -0400
Received: from mx2.parallels.com ([64.131.90.16]:58066 "EHLO mx2.parallels.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932417Ab1ISShr (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 19 Sep 2011 14:37:47 -0400
Message-ID: <4E778BD0.6040607@parallels.com>
Date: Mon, 19 Sep 2011 15:37:04 -0300
From: Glauber Costa <glommer@parallels.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2
MIME-Version: 1.0
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
CC: <linux-kernel@vger.kernel.org>, <xemul@parallels.com>,
        <paul@paulmenage.org>, <lizf@cn.fujitsu.com>, <daniel.lezcano@free.fr>,
        <jbottomley@parallels.com>
Subject: Re: [PATCH 3/9] Include nice values in cpuacct
References: <1316030695-19826-1-git-send-email-glommer@parallels.com>   <1316030695-19826-4-git-send-email-glommer@parallels.com>  <1316449197.6091.6.camel@twins> <4E776D31.9090008@parallels.com> <1316457411.6091.12.camel@twins>
In-Reply-To: <1316457411.6091.12.camel@twins>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [187.106.51.14]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 09/19/2011 03:36 PM, Peter Zijlstra wrote:
> On Mon, 2011-09-19 at 13:26 -0300, Glauber Costa wrote:
>> On 09/19/2011 01:19 PM, Peter Zijlstra wrote:
>>> On Wed, 2011-09-14 at 17:04 -0300, Glauber Costa wrote:
>>>> Besides user and system.
>>>
>>>
>>> Why!?
>> Because this is the whole purpose of this series. Think that in a
>> reasonable use case, each cgroup will be tied to a container system.
>> Each of them wants to have its own statistics, in /proc/stat. The best
>> way I thought of doing it was to piggyback into cpuacct, instead of
>> coming up with a 124th accounting mechanism just for that.
>>
>> I also used it do demonstrate how can we easily implement a new feature
>> found in hypervisors out of it, but this is really just the cherry on top.
>
>
> OK, but then amend the changelog with something like:
>
> Since we want to provide a full /proc/stat equivalent for cgroups, also
> implement nice time.
Fair request.