From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750984Ab1ITOK3 (ORCPT ); Tue, 20 Sep 2011 10:10:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40104 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750866Ab1ITOK0 (ORCPT ); Tue, 20 Sep 2011 10:10:26 -0400 Message-ID: <4E789EA2.8070709@redhat.com> Date: Tue, 20 Sep 2011 10:09:38 -0400 From: Josef Bacik User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2 MIME-Version: 1.0 To: Johannes Weiner CC: Andrew Morton , Mel Gorman , Christoph Hellwig , Dave Chinner , Wu Fengguang , Jan Kara , Rik van Riel , Minchan Kim , Chris Mason , "Theodore Ts'o" , Andreas Dilger , xfs@oss.sgi.com, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [patch 4/4] Btrfs: pass __GFP_WRITE for buffered write page allocations References: <1316526315-16801-1-git-send-email-jweiner@redhat.com> <1316526315-16801-5-git-send-email-jweiner@redhat.com> <20110920135631.GB16338@redhat.com> In-Reply-To: <20110920135631.GB16338@redhat.com> X-Enigmail-Version: 1.3.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/20/2011 09:56 AM, Johannes Weiner wrote: > On Tue, Sep 20, 2011 at 03:45:15PM +0200, Johannes Weiner wrote: >> Tell the page allocator that pages allocated for a buffered write are >> expected to become dirty soon. >> >> Signed-off-by: Johannes Weiner >> --- >> fs/btrfs/file.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c >> index e7872e4..ea1b892 100644 >> --- a/fs/btrfs/file.c >> +++ b/fs/btrfs/file.c >> @@ -1084,7 +1084,7 @@ static noinline int prepare_pages(struct btrfs_root *root, struct file *file, >> again: >> for (i = 0; i < num_pages; i++) { >> pages[i] = find_or_create_page(inode->i_mapping, index + i, >> - GFP_NOFS); >> + GFP_NOFS | __GFP_WRITE); > > Btw and unrelated to this particular series, I think this should use > grab_cache_page_write_begin() in the first place. > > Most grab_cache_page calls were replaced recently (a94733d "Btrfs: use > find_or_create_page instead of grab_cache_page") to be able to pass > GFP_NOFS, but the pages are now also no longer __GFP_HIGHMEM and > __GFP_MOVABLE, which irks both x86_32 and memory hotplug. > > It might be better to change grab_cache_page instead to take a flags > argument that allows passing AOP_FLAG_NOFS and revert the sites back > to this helper? So I can do pages[i] = grab_cache_page_write_begin(inode->i_mapping, index + i, AOP_FLAG_NOFS); right? All we need is nofs, so I can just go through and change everybody to that. I'd rather not have to go through and change grab_cache_page() to take a flags argument and change all the callers, I have a bad habit of screwing stuff like that up :). Thanks, Josef