From: Avi Kivity <avi@redhat.com>
To: Don Zickus <dzickus@redhat.com>
Cc: x86@kernel.org, Andi Kleen <andi@firstfloor.org>,
Robert Richter <robert.richter@amd.com>,
Peter Zijlstra <peterz@infradead.org>,
ying.huang@intel.com, LKML <linux-kernel@vger.kernel.org>,
paulmck@linux.vnet.ibm.com, jeremy@goop.org
Subject: Re: [V5][PATCH 4/6] x86, nmi: add in logic to handle multiple events and unknown NMIs
Date: Wed, 21 Sep 2011 08:45:06 +0300 [thread overview]
Message-ID: <4E7979E2.4020901@redhat.com> (raw)
In-Reply-To: <20110920201051.GL5795@redhat.com>
On 09/20/2011 11:10 PM, Don Zickus wrote:
> On Tue, Sep 20, 2011 at 08:23:03PM +0300, Avi Kivity wrote:
> > >V4:
> > > - clean up fixes, like adding 'static', rename save_rip to last_nmi_rip
> > >
> > >
> >
> > Missing a zeroing of last_nmi_rip in the idle path. Otherwise, as
> > Andi points out, and idle machine will always see NMIs coming in
> > from the hlt/mwait address and detect them as back-to-back NMIs.
>
> You mean something like this?
>
Yes.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next prev parent reply other threads:[~2011-09-21 5:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 14:43 [V5][PATCH 0/6] x86, nmi: new NMI handling routines Don Zickus
2011-09-20 14:43 ` [V5][PATCH 1/6] x86, nmi: split out nmi from traps.c Don Zickus
2011-09-20 14:43 ` [V5][PATCH 2/6] x86, nmi: create new NMI handler routines Don Zickus
2011-09-21 5:36 ` Huang Ying
2011-09-21 13:56 ` Don Zickus
2011-09-20 14:43 ` [V5][PATCH 3/6] x86, nmi: wire up NMI handlers to new routines Don Zickus
2011-09-21 5:41 ` Huang Ying
2011-09-21 10:49 ` Borislav Petkov
2011-09-21 14:06 ` Don Zickus
2011-09-20 14:43 ` [V5][PATCH 4/6] x86, nmi: add in logic to handle multiple events and unknown NMIs Don Zickus
2011-09-20 17:23 ` Avi Kivity
2011-09-20 20:10 ` Don Zickus
2011-09-21 5:45 ` Avi Kivity [this message]
2011-09-21 5:43 ` Huang Ying
2011-09-21 13:57 ` Don Zickus
2011-09-21 10:08 ` Robert Richter
2011-09-21 14:04 ` Don Zickus
2011-09-21 15:18 ` Robert Richter
2011-09-21 15:33 ` Peter Zijlstra
2011-09-21 16:04 ` Robert Richter
2011-09-21 16:40 ` Peter Zijlstra
2011-09-21 16:13 ` Don Zickus
2011-09-21 16:24 ` Avi Kivity
2011-09-21 16:54 ` Robert Richter
2011-09-25 12:54 ` Avi Kivity
2011-09-21 17:10 ` Don Zickus
2011-09-20 14:43 ` [V5][PATCH 5/6] x86, nmi: track NMI usage stats Don Zickus
2011-09-20 14:43 ` [V5][PATCH 6/6] x86, nmi: print out NMI stats in /proc/interrupts Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E7979E2.4020901@redhat.com \
--to=avi@redhat.com \
--cc=andi@firstfloor.org \
--cc=dzickus@redhat.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=robert.richter@amd.com \
--cc=x86@kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).