From: Jens Axboe <axboe@kernel.dk>
To: Matthew Wilcox <matthew@wil.cx>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: xen_biovec_phys_mergeable not exported
Date: Wed, 21 Sep 2011 14:09:40 +0200 [thread overview]
Message-ID: <4E79D404.7000805@kernel.dk> (raw)
In-Reply-To: <20110920202553.GB16740@parisc-linux.org>
On 2011-09-20 22:25, Matthew Wilcox wrote:
>
> In my NVMe driver, I call BIOVEC_PHYS_MERGEABLE(). If CONFIG_XEN
> is defined, it references xen_biovec_phys_mergeable() which is not
> EXPORT_SYMBOL. I think BIOVEC_PHYS_MERGABLE is a perfectly kosher thing
> to be calling from a module that implements a bio-based block driver,
> so I think the right thing to do is to add an EXPORT_SYMBOL(_GPL?) to
> the Xen code when I submit the driver.
>
> Does anyone have a different opinion on this?
Yep, lets just export it for now. Long term, that functionality will be
moving back into the block layer when we unify the queuing models.
--
Jens Axboe
next prev parent reply other threads:[~2011-09-21 12:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 20:25 xen_biovec_phys_mergeable not exported Matthew Wilcox
2011-09-21 12:09 ` Jens Axboe [this message]
2011-09-21 18:46 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E79D404.7000805@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).