From: Yinghai Lu <yinghai.lu@oracle.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
oneukum@suse.de, x86@kernel.org,
Linux PM mailing list <linux-pm@lists.linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: S4 resume broken since 2.6.39 (3.1, too)
Date: Mon, 26 Sep 2011 19:26:44 -0700 [thread overview]
Message-ID: <4E813464.80105@oracle.com> (raw)
In-Reply-To: <s5hty84fnv7.wl%tiwai@suse.de>
On 09/22/2011 11:11 AM, Takashi Iwai wrote:
> At Thu, 22 Sep 2011 07:33:17 -0700,
> Yinghai Lu wrote:
>>
>> On Wed, Sep 21, 2011 at 11:48 AM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
>>> It looks like init_memory_mapping() is sometimes called with "end"
>>> beyond the last mapped PFN and it explodes when we try to write stuff to
>>> that address during image restoration.
>>>
>>> IOW, the Yinghai's assumption that init_memory_mapping() would always be
>>> called with a "good end" on x86_64 was overomptimistic.
>>
>> for 64bit x86, kernel_physical_mapping_init() will use
>> map_low_page()/call early_memmap() to access ram for page_table that is above
>> rather last mapped PFN.
>>
>> the point is:
>> on system with 64g, usable ram will be [0,2048m), [4g, 64g)
>> init_memory_mapping will be called two times for them.
>> before putting page_table high,
>> page table will be two parts: one is just below 512M, and one below 2048m.
>> after putting page_table high,
>> page table will be two parts: one is just below 2048M, and one below 64G.
>
> So, how can this change break S4 resume?
not sure.
seems resume has it's own page table during transition...
> Any hint for further debugging?
you may try to insert dead loop in arch/x86/power/hibernate_asm_64.S::restore_image or core_restore_code
to see which part cause reset.
Yinghai
next prev parent reply other threads:[~2011-09-27 2:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 16:12 S4 resume broken since 2.6.39 (3.1, too) Takashi Iwai
2011-09-21 18:48 ` Rafael J. Wysocki
2011-09-22 9:49 ` Takashi Iwai
2011-09-22 14:33 ` Yinghai Lu
2011-09-22 18:11 ` Takashi Iwai
2011-09-27 2:26 ` Yinghai Lu [this message]
2011-09-27 16:38 ` Takashi Iwai
2011-09-27 16:54 ` Yinghai Lu
2011-09-28 10:08 ` Takashi Iwai
2011-09-27 16:56 ` Rafael J. Wysocki
2011-09-28 10:09 ` Takashi Iwai
2011-09-28 13:26 ` Rafael J. Wysocki
2011-09-28 13:28 ` Takashi Iwai
2011-09-28 14:29 ` Takashi Iwai
2011-09-28 14:45 ` Rafael J. Wysocki
2011-09-28 14:45 ` Takashi Iwai
2011-09-28 16:19 ` Takashi Iwai
2011-09-28 18:05 ` Takashi Iwai
2011-09-28 19:30 ` Rafael J. Wysocki
2011-09-26 22:24 ` Rafael J. Wysocki
2011-09-26 22:47 ` Linus Torvalds
2011-09-27 2:48 ` Yinghai Lu
2011-09-27 2:34 ` Yinghai Lu
2011-09-27 17:03 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E813464.80105@oracle.com \
--to=yinghai.lu@oracle.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mingo@redhat.com \
--cc=oneukum@suse.de \
--cc=rjw@sisk.pl \
--cc=tiwai@suse.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox