From: Frank Rowand <frank.rowand@am.sony.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Rowand, Frank" <Frank_Rowand@sonyusa.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PREEMPT_RT_FULL: arm coredump fails for cpu >= 4
Date: Wed, 28 Sep 2011 11:33:33 -0700 [thread overview]
Message-ID: <4E83687D.1070507@am.sony.com> (raw)
In-Reply-To: <1317214993.24040.16.camel@twins>
On 09/28/11 06:03, Peter Zijlstra wrote:
> On Tue, 2011-09-27 at 20:02 -0700, Frank Rowand wrote:
>>
>> ARM can not use SPLIT_PTLOCK_CPUS if PREEMPT_RT_FULL because
>> vectors_user_mapping() creates a VM_ALWAYSDUMP mapping of the vector page,
>> but no ptl->lock has been allocated for the page. An attempt to coredump
>> that page will result in a kernel NULL pointer dereference when
>> follow_page() attempts to lock the page.
>
>
>>
>> This patch is needed only if mm-shrink-the-page-frame-to-rt-size.patch is
>> applied.
>
> Yeah, vile hackery that is.. why isn't pgtable_page_ctor() called on
> those pages?
Yep, that is the question. I started fixing that yesterday, but realized
I was going about it the wrong way, so I sent a first version of the
patch that simply avoids the problem.
I'll be looking at whether I can fix it cleanly.
>
> Not that I care too much about split_pte_lock on ARM, they're mostly all
> tiny machines anyway so the gain is marginal, but it would be good to
> find out why the pgtable constructor isn't called properly.
>
next prev parent reply other threads:[~2011-09-28 18:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-28 3:02 [PATCH] PREEMPT_RT_FULL: arm coredump fails for cpu >= 4 Frank Rowand
2011-09-28 13:03 ` Peter Zijlstra
2011-09-28 18:33 ` Frank Rowand [this message]
2011-10-02 1:58 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E83687D.1070507@am.sony.com \
--to=frank.rowand@am.sony.com \
--cc=Frank_Rowand@sonyusa.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox