From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755825Ab1I3A62 (ORCPT ); Thu, 29 Sep 2011 20:58:28 -0400 Received: from mail-gy0-f174.google.com ([209.85.160.174]:46017 "EHLO mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755636Ab1I3A61 (ORCPT ); Thu, 29 Sep 2011 20:58:27 -0400 Message-ID: <4E85142C.101@gmail.com> Date: Thu, 29 Sep 2011 18:58:20 -0600 From: David Ahern User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2 MIME-Version: 1.0 To: Arnaldo Carvalho de Melo CC: Jiri Olsa , a.p.zijlstra@chello.nl, mingo@elte.hu, Stephane Eranian , paulus@samba.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf tools: Exit recording if events have non matching sample type References: <20110929230613.GA20083@ghostprotocols.net> <4E850056.1090101@gmail.com> <20110930004018.GA9369@ghostprotocols.net> In-Reply-To: <20110930004018.GA9369@ghostprotocols.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/29/2011 06:40 PM, Arnaldo Carvalho de Melo wrote: > Em Thu, Sep 29, 2011 at 05:33:42PM -0600, David Ahern escreveu: >> On 09/29/2011 05:06 PM, Arnaldo Carvalho de Melo wrote: >>>> >From what I can see sample_type has to be the same for all samples: >>>> https://lkml.org/lkml/2011/8/15/6 > >>> We could add a PERF_SAMPLE_ID2 that if present would be guaranteed >>> to be the last, or we can, as PeterZ prefers/suggests, to use one >>> mmap per sample id, then we know that if we're getting it on that >>> mmap, it has that sample_type. > >>> For record that means we need to dump each per-sample_id mmap onto a >>> separate file, i.e. use a directory, etc. > >> That seems like a major re-write of perf. Why not keep the existing >> restriction and have users who want different sample_types run >> multiple perf commands? > >> What's to be gained by refactoring the code to support multiple >> sample_types in a single command invocation? > > This comes from time to time: > > http://us.generation-nt.com/answer/bug-perf-event-sampling-buffer-format-cannot-handle-multi-event-sampling-help-202985832.html > > The whole point of sample_type is to ask for just what is needed for > some specific event so that we reduce the per sample footprint. > > So we allow for multiple types of events to be on the same stream, but > not for them to have just what each need, its a limitation, one that we > can solve. I see no reason not to solve it :-) > > The evsel/evlist classes were designed to abstract away such details, > i.e. perf_evlist__mmap should notice different sample_types and sort > this out transparently. > > And then perf_evlist__mmap_read(evlist, idx), evlist->nr_mmaps should be > enough to process the events :-) > > - Arnaldo An ABI change fixes the root cause of the current problem -- put an id in perf_event_header. The id maps to the evsel which has the sample_type. Right now you have to parse the sample to get the id to get the evsel. With that change I have a patch that (mostly?) covers the rest of perf userspace to handle sample_type per evsel. David