From: Avi Kivity <avi@redhat.com>
To: Jon Mason <mason@myri.com>
Cc: Sven Schnelle <svens@stackframe.org>,
Simon Kirby <sim@hostway.ca>,
Eric Dumazet <eric.dumazet@gmail.com>,
Niels Ole Salscheider <niels_ole@salscheider-online.de>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Ben Hutchings <bhutchings@solarflare.com>
Subject: Re: Workaround for Intel MPS errata
Date: Mon, 03 Oct 2011 12:11:53 +0200 [thread overview]
Message-ID: <4E898A69.8060306@redhat.com> (raw)
In-Reply-To: <20111003045823.GA13222@myri.com>
On 10/03/2011 06:58 AM, Jon Mason wrote:
> On Sun, Oct 02, 2011 at 11:26:12AM +0200, Avi Kivity wrote:
> > On 09/30/2011 03:16 AM, Jon Mason wrote:
> > >Hey Avi,
> > >Can you try this patch? It should resolve the issue you are seeing.
> >
> > It doesn't; the fixup: label is not reached (though I do have an
> > 0x25d4 device).
> >
> > --
> > error compiling committee.c: too many arguments to function
> >
>
> I found a system with a 5000X Memory controller (which should have the
> same errata). It doesn't have the faulty bit (perhaps better BIOS). I
> was able to findout why the code in the previous patch wasn't working,
> but wasn't able to cause the crash by setting the bit from the errata.
> The reworked version of the previous patch found below should resolve
> the issue. Please test it if you can.
Will be happy to test, but patch appears to be against a different tree?
$ git apply -C2 .git/rebase-apply/patch
.git/rebase-apply/patch:75: trailing whitespace, shock horror.
*
Context reduced to (2/2) to apply fragment at 1362
Context reduced to (2/2) to apply fragment at 1475
error: patch failed: drivers/pci/probe.c:1433
error: drivers/pci/probe.c: patch does not apply
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-10-03 10:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-27 17:01 [REGRESSION] e1000e failure triggered by "PCI: Remove MRRS modification from MPS setting code" Avi Kivity
2011-09-27 17:59 ` Jon Mason
2011-09-27 18:28 ` Avi Kivity
2011-09-27 20:11 ` Jon Mason
2011-09-29 4:33 ` Benjamin Herrenschmidt
2011-09-29 13:53 ` Jon Mason
2011-09-30 0:16 ` Workaround for Intel MPS errata Jon Mason
2011-09-30 2:21 ` Jesse Brandeburg
2011-09-30 2:51 ` Jon Mason
2011-09-30 5:01 ` Bjorn Helgaas
2011-09-30 15:35 ` Jon Mason
2011-09-30 17:17 ` Bjorn Helgaas
2011-09-30 17:38 ` Jon Mason
2011-09-30 17:57 ` Bjorn Helgaas
2011-09-30 7:03 ` Rolf Eike Beer
2011-09-30 15:39 ` Jon Mason
2011-10-02 9:26 ` Avi Kivity
2011-10-03 4:58 ` Jon Mason
2011-10-03 10:11 ` Avi Kivity [this message]
2011-10-03 15:12 ` Jon Mason
2011-10-04 9:46 ` Avi Kivity
2011-10-04 13:06 ` Avi Kivity
2011-10-04 13:11 ` Jon Mason
2011-10-04 20:12 ` Jon Mason
2011-10-05 3:46 ` Jon Mason
2011-10-05 12:09 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E898A69.8060306@redhat.com \
--to=avi@redhat.com \
--cc=bhutchings@solarflare.com \
--cc=eric.dumazet@gmail.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mason@myri.com \
--cc=niels_ole@salscheider-online.de \
--cc=sim@hostway.ca \
--cc=svens@stackframe.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).