Re: [PATCH] ramoops: scripts/ramoops.c for extracting oopses

["Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>]

Hi,

On 10/05/2011 11:55 PM, Thomas Tuttle wrote:
> +static int print_records(int record)
> +{
> +	unsigned long mem_address, mem_size, record_size, num_records;
> +	FILE *mem;
> +	int i;
> +	int ret = 0;
> +
> +	read_long(RAMOOPS_PARAM "mem_address", &mem_address);
> +	read_long(RAMOOPS_PARAM "mem_size",    &mem_size);
> +	read_long(RAMOOPS_PARAM "record_size", &record_size);
> +	num_records = mem_size / record_size;
> +
> +	if (record != REC_LIST &&
> +	    (record < 0 || (unsigned long)record >= num_records)) {
> +		fprintf(stderr, "%s: record number %d out of range [0, %ld)\n",
> +			progn, record, num_records);
> +		return 1;
> +	}
> +
> +	buf = malloc(record_size);

Since buf is not declared, this fails program compilation.

> +	if (!buf) {
> +		fprintf(stderr, "%s: failed to allocate record buffer\n",
> +			progn);
> +		return 1;
> +	}
> +

-- 
Regards,
Srivatsa S. Bhat  <srivatsa.bhat@linux.vnet.ibm.com>
Linux Technology Center,
IBM India Systems and Technology Lab