public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@cam.ac.uk>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: greg@kroah.com, Mark Brown <broonie@opensource.wolfsonmicro.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC] drivercore: Add helper macro for platform_driver boilerplate
Date: Thu, 06 Oct 2011 12:40:39 +0100	[thread overview]
Message-ID: <4E8D93B7.4010802@cam.ac.uk> (raw)
In-Reply-To: <20111004232403.10364.22050.stgit@ponder>

On 10/05/11 00:26, Grant Likely wrote:
> For simple modules that contain a single platform_driver without any
> additional setup code then ends up being a block of duplicated
> boilerplate.  This patch adds a new macro, module_platform_driver(),
> which replaces the module_init()/module_exit() registrations with
> template functions.
> 
> This patch also converts all the relevant spi drivers to use the new
> macro.  There are a lot of drivers in the tree that are using this
> pattern and could be converted.
> 
> It also fixes up some incorrect section annotations where I found
> them.
> 
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> ---
> 
> I think this is useful, and I like the diffstat that it produces.
> What does everyone else think of this approach?  I can do versions for
> i2c_drivers and spi_drivers too.
Excellent idea.  Great to shrink this boilerplate where ever you can.
i2c and spi version would be excellent.  Look to be 426 instances
(I haven't checked but most are of the standard trivial form). So that is
another few thousand lines gone. It's getting on for 500 in IIO alone where
they are all of the trivial form, so this will make me very happy :)

Thanks Grant!

Jonathan

  parent reply	other threads:[~2011-10-06 11:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-04 23:26 [RFC] drivercore: Add helper macro for platform_driver boilerplate Grant Likely
2011-10-05  6:56 ` Greg KH
2011-10-05 16:43   ` Grant Likely
2011-10-05 19:29     ` Greg KH
2011-12-04  8:39   ` Geert Uytterhoeven
2011-12-04  9:36     ` Lars-Peter Clausen
2011-12-04 10:27       ` Geert Uytterhoeven
2011-10-05  8:12 ` Magnus Damm
2011-10-05 10:02 ` Mark Brown
2011-10-05 16:42   ` Grant Likely
2011-10-05 21:37 ` Stephen Boyd
2011-10-06  0:58   ` Grant Likely
2011-10-06 11:40 ` Jonathan Cameron [this message]
2011-10-06 14:50 ` Mike Frysinger
2011-10-06 18:35 ` Tabi Timur-B04825

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E8D93B7.4010802@cam.ac.uk \
    --to=jic23@cam.ac.uk \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=grant.likely@secretlab.ca \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox