From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964967Ab1JFPsB (ORCPT ); Thu, 6 Oct 2011 11:48:01 -0400 Received: from e28smtp02.in.ibm.com ([122.248.162.2]:35934 "EHLO e28smtp02.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935529Ab1JFPsA (ORCPT ); Thu, 6 Oct 2011 11:48:00 -0400 Message-ID: <4E8DCDA6.8030802@linux.vnet.ibm.com> Date: Thu, 06 Oct 2011 21:17:50 +0530 From: "Srivatsa S. Bhat" User-Agent: Mozilla/5.0 (X11; Linux i686; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2 MIME-Version: 1.0 To: Borislav Petkov CC: "Rafael J. Wysocki" , Borislav Petkov , Tejun Heo , "tigran@aivazian.fsnet.co.uk" , "tglx@linutronix.de" , "mingo@elte.hu" , "hpa@zytor.com" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , Linux PM mailing list Subject: Re: [BUGFIX][PATCH] Freezer, CPU hotplug, x86 Microcode: Fix task freezing failures References: <20111002195023.GC31799@mtj.dyndns.org> <201110052226.58373.rjw@sisk.pl> <4E8CC8FA.2090100@linux.vnet.ibm.com> <201110060043.19583.rjw@sisk.pl> <4E8D4FC6.1080204@linux.vnet.ibm.com> <20111006083439.GA21575@aftab> In-Reply-To: <20111006083439.GA21575@aftab> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/06/2011 02:04 PM, Borislav Petkov wrote: > On Thu, Oct 06, 2011 at 02:50:46AM -0400, Srivatsa S. Bhat wrote: >> On 10/06/2011 04:13 AM, Rafael J. Wysocki wrote: >>> On Wednesday, October 05, 2011, Srivatsa S. Bhat wrote: >>>> On 10/06/2011 01:56 AM, Rafael J. Wysocki wrote: >>>>> >>>>> OK, can you please repost the patch with Borislav's Acked-by and Tested-by >>>>> and add some more Intel people to the CC list? >>>>> >>>> >>>> Sure, I'll do that. Thank you. >>>> But are we not going to consider a cleaner/correct solution such as the >>>> one proposed here: >>>> http://permalink.gmane.org/gmane.linux.kernel/1199494 >>>> >>>> Well, honestly I don't mean to be stubborn, but somehow, knowing that >>>> there are issues with my patch doesn't make me feel very comfortable >>>> going with it, especially when there is another approach, which I >>>> believe can fix the issue properly, without undesirable side-effects. >>>> >>>> I agree that the issues are mostly some corner cases, so if you want a >>>> quick fix for now, I guess we can go with this patch and then later on >>>> follow-up with a proper solution to this whole problem. >>> >>> It ultimately is your call. If you feel more comfortable with the >>> alternative, just post that one instead. >>> >> Cool! I am working on implementing that other solution. I'll post it as soon >> as I am done writing and testing that patch. > > Please test your other patch which removes the CPU_DEAD line from the > microcode CPU hotplug callback on an Intel box with microcode too and > submit it. This fix makes sense irrespective of a suspend/resume fix > because reloading the ucode when onlining the CPU is clearly unneeded. > Ok, I tested both these scenarios on Intel boxes: 1. cpu hotplug stress test + pm_test in parallel 2. loading/unloading microcode etc. They all work fine. I'll post that one-line patch with your Acked-by and Tested-by. Thank you very much. -- Regards, Srivatsa S. Bhat Linux Technology Center, IBM India Systems and Technology Lab