From: "H. Peter Anvin" <hpa@zytor.com>
To: Alex Ben <aleben358@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <Mingo@redhat.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: Removed superfluous parentheses in macro defs
Date: Thu, 06 Oct 2011 20:18:00 -0700 [thread overview]
Message-ID: <4E8E6F68.9050104@zytor.com> (raw)
In-Reply-To: <1317939724-27924-1-git-send-email-aleben358@gmail.com>
On 10/06/2011 03:22 PM, Alex Ben wrote:
> 1) make it consistent with other constant macro deinitions, which
> don't have parentheses, as they are really superfluous.
Superfluous, yes, but it makes the expression read more regular.
> diff --git a/arch/x86/include/asm/segment.h b/arch/x86/include/asm/segment.h
> index 5e64171..92621c1 100644
> --- a/arch/x86/include/asm/segment.h
> +++ b/arch/x86/include/asm/segment.h
> @@ -10,7 +10,7 @@
> (((flags) & _AC(0x0000f0ff,ULL)) << 40) | \
> (((limit) & _AC(0x000f0000,ULL)) << (48-16)) | \
> (((base) & _AC(0x00ffffff,ULL)) << 16) | \
> - (((limit) & _AC(0x0000ffff,ULL))))
> + ((limit) & _AC(0x0000ffff,ULL)))
>
So NAK.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
prev parent reply other threads:[~2011-10-07 3:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 22:22 [PATCH] x86: Removed superfluous parentheses in macro defs Alex Ben
2011-10-06 22:50 ` Borislav Petkov
2011-10-07 3:18 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8E6F68.9050104@zytor.com \
--to=hpa@zytor.com \
--cc=Mingo@redhat.com \
--cc=aleben358@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox