From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754598Ab1JHDVa (ORCPT <rfc822;w@1wt.eu>);
	Fri, 7 Oct 2011 23:21:30 -0400
Received: from acsinet15.oracle.com ([141.146.126.227]:52022 "EHLO
	acsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754034Ab1JHDV3 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 7 Oct 2011 23:21:29 -0400
Message-ID: <4E8FC19F.9060305@oracle.com>
Date: Sat, 08 Oct 2011 11:21:03 +0800
From: Joe Jin <joe.jin@oracle.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0
MIME-Version: 1.0
To: Matt Carlson <mcarlson@broadcom.com>
CC: Xiao Jiang <jgq516@gmail.com>, Michael Chan <mchan@broadcom.com>,
        Guru Anbalagane <guru.anbalagane@oracle.com>,
        Gurudas Pai <gurudas.pai@oracle.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Greg Marsden <greg.marsden@oracle.com>
Subject: Re: [PATCH] tg3: Dont dump registers if interface not ready.
References: <4E83D3B3.7090508@oracle.com> <4E841519.6040201@gmail.com> <20111005021423.GA2787@mcarlson.broadcom.com>
In-Reply-To: <20111005021423.GA2787@mcarlson.broadcom.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Source-IP: ucsinet24.oracle.com [156.151.31.67]
X-CT-RefId: str=0001.0A090203.4E8FC1B7.001A,ss=1,re=0.000,fgs=0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>>>  
>>> +	/* If interface not ready then dont dump error */
>>> +	if (!netif_carrier_ok(tp->dev))
>>> +		dump = false;
> 
> Would you still experience the problem if you did the following instead
> of the above link check?
> 
> 		if (tg3_flag(tp, INIT_COMPLETE))
> 			dump = false;

I'll try it then update you.

Thanks,
Joe