public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-kernel@vger.kernel.org, xiyou.wangcong@gmail.com,
	viro@zeniv.linux.org.uk, dchinner@redhat.com
Subject: Re: [PATCH v2] ramfs: Remove module leftovers
Date: Mon, 10 Oct 2011 13:13:22 +0200	[thread overview]
Message-ID: <4E92D352.1030109@nod.at> (raw)
In-Reply-To: <20111010110907.GB28672@lst.de>

[-- Attachment #1: Type: text/plain, Size: 523 bytes --]

Am 10.10.2011 13:09, schrieb Christoph Hellwig:
> On Mon, Oct 10, 2011 at 12:54:39PM +0200, Richard Weinberger wrote:
>> Since ramfs is hard-selected to "y", the module leftovers make
>> no sense.
> 
> Removing the dead code looks good, but what is the point in using
> device_initcall?  We've always been using module_init for non-modular
> code, though.
> 

Ah, ok!
So we can keep the module_init()?
I was not sure whether it's valid to use module_init() in pure
non-modular code...

Thanks,
//richard


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

  reply	other threads:[~2011-10-10 11:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-10 10:54 [PATCH v2] ramfs: Remove module leftovers Richard Weinberger
2011-10-10 11:09 ` Christoph Hellwig
2011-10-10 11:13   ` Richard Weinberger [this message]
2011-10-10 11:24     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E92D352.1030109@nod.at \
    --to=richard@nod.at \
    --cc=dchinner@redhat.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox