From: Ryan Mallon <rmallon@gmail.com>
To: Hartmut Knaack <knaack.h@gmx.de>
Cc: Grant Likely <grant.likely@secretlab.ca>, linux-kernel@vger.kernel.org
Subject: Re: [Patch 2/2] gpio-pca953x: fix gpio_base and add verbosity
Date: Tue, 11 Oct 2011 09:37:10 +1100 [thread overview]
Message-ID: <4E937396.7090100@gmail.com> (raw)
In-Reply-To: <4E93703C.9050307@gmx.de>
On 11/10/11 09:22, Hartmut Knaack wrote:
> Inspired by the gpio-pcf857x driver, this patch will output information
> about the instantiated gpio-chip, including gpio start and end, chip
> type and if irq is used.
>
> Signed-off-by: Hartmut Knaack <knaack.h@gmx.de>
> -------------------------------------------------------------
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index ae479fd..4bdb88e 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -683,6 +683,12 @@ static int __devinit pca953x_probe(struct
> i2c_client *client,
> if (ret)
> goto out_failed;
>
> + dev_info(&client->dev, "gpios %d..%d added on a %s%s\n",
> + chip->gpio_chip.base,
> + chip->gpio_chip.base + chip->gpio_chip.ngpio - 1,
> + client->name,
> + client->irq ? " (irq ignored)" : "");
> +
If we want this, why not move it into gpiochip_add rather than
duplicating it in each driver? If you want to keep it here it should
probably be moved below the gpiochip_add, since the above would still
print if gpiochip_add failed.
> ret = gpiochip_add(&chip->gpio_chip);
> if (ret)
> goto out_failed_irq;
>
~Ryan
prev parent reply other threads:[~2011-10-10 22:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 22:22 [Patch 2/2] gpio-pca953x: fix gpio_base and add verbosity Hartmut Knaack
2011-10-10 22:37 ` Ryan Mallon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E937396.7090100@gmail.com \
--to=rmallon@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=knaack.h@gmx.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox