From: "Cousson, Benoit" <b-cousson@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: "Munegowda, Keshava" <keshava_mgowda@ti.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Balbi, Felipe" <balbi@ti.com>, "Hilman, Kevin" <khilman@ti.com>,
"Gadiyar, Anand" <gadiyar@ti.com>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
"parthab@india.ti.com" <parthab@india.ti.com>,
"tony@atomide.com" <tony@atomide.com>,
"johnstul@us.ibm.com" <johnstul@us.ibm.com>,
"Sripathy, Vishwanath" <vishwanath.bs@ti.com>
Subject: Re: [PATCH 1/5 v13] arm: omap: usb: ehci and ohci hwmod structures for omap4
Date: Tue, 11 Oct 2011 10:01:54 +0200 [thread overview]
Message-ID: <4E93F7F2.5090805@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1110101838500.5205@utopia.booyaka.com>
Hi Paul,
On 10/11/2011 2:40 AM, Paul Walmsley wrote:
> Hi
>
> and some comments on this one ...
>
> On Thu, 6 Oct 2011, Keshava Munegowda wrote:
[...]
>> +static struct omap_hwmod_ocp_if omap44xx_l4_cfg__usb_tll_hs = {
>> + .master =&omap44xx_l4_cfg_hwmod,
>> + .slave =&omap44xx_usb_tll_hs_hwmod,
>> + .addr = omap44xx_usb_tll_hs_addrs,
>> + .user = OCP_USER_MPU | OCP_USER_SDMA,
>> +};
>
> This one has the .master pointing to something reasonable, but is missing
> a .clk entry.
In that case, there is only an interface clock and a couple of optional
clocks, that why I did not populate the main_clk.
IIRC, we decided to not duplicate the iclk into the main_clk in case of
module that are using only the interface clock as their functional clock.
Regards,
Benoit
prev parent reply other threads:[~2011-10-11 8:02 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 11:38 [PATCH 1/5 v13] arm: omap: usb: ehci and ohci hwmod structures for omap4 Keshava Munegowda
2011-10-07 9:06 ` Paul Walmsley
2011-10-07 9:21 ` Munegowda, Keshava
2011-10-07 9:35 ` Paul Walmsley
2011-10-07 10:33 ` Munegowda, Keshava
2011-10-10 8:52 ` Munegowda, Keshava
2011-10-10 9:03 ` Felipe Balbi
2011-10-10 9:17 ` Munegowda, Keshava
2011-10-10 9:26 ` Felipe Balbi
2011-10-10 10:05 ` Felipe Balbi
2011-10-10 11:15 ` Munegowda, Keshava
2011-10-10 15:19 ` Alan Stern
2011-10-10 16:03 ` Felipe Balbi
2011-10-10 19:55 ` Alan Stern
2011-10-10 20:10 ` Felipe Balbi
2011-10-11 0:15 ` Alan Stern
2011-10-11 8:13 ` Felipe Balbi
2011-10-11 14:04 ` Alan Stern
2011-10-11 14:08 ` Felipe Balbi
2011-10-11 18:52 ` Paul Walmsley
2011-10-11 19:12 ` Felipe Balbi
2011-10-11 19:17 ` Paul Walmsley
2011-10-11 19:19 ` Felipe Balbi
2011-10-10 21:49 ` Paul Walmsley
2011-10-10 22:13 ` Paul Walmsley
2011-10-10 20:59 ` Paul Walmsley
2011-10-11 1:18 ` Paul Walmsley
2011-10-07 10:43 ` Munegowda, Keshava
2011-10-07 14:27 ` Munegowda, Keshava
2011-10-11 0:40 ` Paul Walmsley
2011-10-11 8:01 ` Cousson, Benoit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E93F7F2.5090805@ti.com \
--to=b-cousson@ti.com \
--cc=balbi@ti.com \
--cc=gadiyar@ti.com \
--cc=johnstul@us.ibm.com \
--cc=keshava_mgowda@ti.com \
--cc=khilman@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=parthab@india.ti.com \
--cc=paul@pwsan.com \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
--cc=vishwanath.bs@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox