From: "Ying-Chun Liu (PaulLiu)" <paul.liu@linaro.org>
To: ashish.jangam@kpitcummins.com
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
linaro-dev@lists.linaro.org, lrg@slimlogic.co.uk,
linux-kernel@vger.kernel.org, Dajun <dajun.chen@diasemi.com>
Subject: Re: [Patch 5/11] Regulator: DA9052/53 regulator support v4
Date: Wed, 12 Oct 2011 21:56:12 +0800 [thread overview]
Message-ID: <4E959C7C.40901@linaro.org> (raw)
In-Reply-To: <1317990038.5372.6.camel@L-0761.kpit.com>
(2011年10月07日 20:20), ashishj3 wrote:
> The Dialog PMIC has below featured regulators:-
> DA9052-BC - 4 DVS Buck converters 0.5V - 3.6V upto 1Amp.
> DA9053-AA/BX - 4 DVS Buck converters 0.5V - 2.5V upto 3Amp.
> DA9052/53 - 10 Programmable LDO's High PSSR, 1% accuracy.
>
> This patch support all the DA9052 and Da9053 regulators. The output voltages are
> fully programmable via I2C or SPI interface. The platform data with regulation
> constraints is passed down from the board to the regulator.
>
> Signed-off-by: David Dajun Chen <dchen@diasemi.com>
> Signed-off-by: Ashish Jangam <ashish.jangam@kpitcummins.com>
> CC: Mark Brown <broonie@opensource.wolfsonmicro.com>
Tested-by: Ying-Chun Liu (PaulLiu) <paul.liu@linaro.org>
Hi,
I've reviewed the source code and tested this driver on imx53 QuickStart
board. Works good.
There are some minor warnings and error by running checkpatch.pl on this
patch.
WARNING: please write a paragraph that describes the config symbol fully
#50: FILE: drivers/regulator/Kconfig:173:
+ help
ERROR: do not set execute permissions for source files
#70: FILE: drivers/regulator/da9052-regulator.c
WARNING: line over 80 characters
#117: FILE: drivers/regulator/da9052-regulator.c:43:
+ {800000, 1000000, 1200000, 1500000}, /* DA9053-AA/Bx BUCK-PRO,MEM,PERI */
Yours Sincerely,
Paul
next prev parent reply other threads:[~2011-10-12 13:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 12:20 [Patch 5/11] Regulator: DA9052/53 regulator support v4 ashishj3
2011-10-12 13:56 ` Ying-Chun Liu (PaulLiu) [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-10-07 12:20 ashishj3
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E959C7C.40901@linaro.org \
--to=paul.liu@linaro.org \
--cc=ashish.jangam@kpitcummins.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dajun.chen@diasemi.com \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox