Re: [Xen-devel] [PATCH 0/3] x86/microcode: support for microcode update in Xen dom0

Jeremy Fitzhardinge
2011-11-03T16:47:13Z

On 11/03/2011 08:06 AM, Ben Guthro wrote:
> After pulling in this change from your tree, I found the following
> bug, when checking an enum value, which should be considered before
> inclusion:
>
>
> diff --git a/arch/x86/kernel/microcode_xen.c
> b/arch/x86/kernel/microcode_xen.c
> index 9d2a06b..6a73957 100644
> --- a/arch/x86/kernel/microcode_xen.c
> +++ b/arch/x86/kernel/microcode_xen.c
> @@ -157,7 +157,7 @@ static enum ucode_state
> xen_request_microcode_user(int cpu,
> ret = UCODE_OK;
>
> out:
> -if (ret == 0)
> +if (ret == UCODE_OK)
> uci->mc = uc;
> else
> vfree(uc);

Thanks!

J