From: "H. Peter Anvin" <hpa@kernel.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/3] x86, intel: Output microcode revision v6
Date: Wed, 12 Oct 2011 22:37:52 -0700 [thread overview]
Message-ID: <4E967930.1020409@kernel.org> (raw)
In-Reply-To: <1318466795-7393-1-git-send-email-andi@firstfloor.org>
On 10/12/2011 05:46 PM, Andi Kleen wrote:
>
> I had to add a memory barrier to native_cpuid to prevent it being
> optimized away when the result is not used.
>
This is BAD... this means gcc is optimizing away an asm volatile, which
should never happen. Please report a gcc bug. What version of gcc is this?
Other than that,
Acked-by: H. Peter Anvin <hpa@zytor.com>
next prev parent reply other threads:[~2011-10-13 5:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-13 0:46 [PATCH 1/3] x86, intel: Output microcode revision v6 Andi Kleen
2011-10-13 0:46 ` [PATCH 2/3] x86, intel: Use cpu_update for Atom errata check Andi Kleen
2011-10-13 5:38 ` H. Peter Anvin
2011-10-13 0:46 ` [PATCH 3/3] coretemp: Get microcode revision from cpu_data v3 Andi Kleen
2011-10-13 5:38 ` H. Peter Anvin
2011-10-13 16:11 ` Yu, Fenghua
2011-10-13 5:37 ` H. Peter Anvin [this message]
2011-10-13 12:53 ` [PATCH 1/3] x86, intel: Output microcode revision v6 Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E967930.1020409@kernel.org \
--to=hpa@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox