public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] [TRIVIAL] microblaze: add missing CONFIG_ prefixes
@ 2011-10-12 19:28 Paul Bolle
  2011-10-13  8:34 ` Jiri Kosina
  0 siblings, 1 reply; 3+ messages in thread
From: Paul Bolle @ 2011-10-12 19:28 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: linux-kernel, Michal Simek, microblaze-uclinux

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Entirely untested. Somehow, I don't feel too bad about that. Added the
maintainer and the mailinglist because this could change the behavior of
this code.

 arch/microblaze/mm/init.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/microblaze/mm/init.c b/arch/microblaze/mm/init.c
index 213f2d6..36a133e 100644
--- a/arch/microblaze/mm/init.c
+++ b/arch/microblaze/mm/init.c
@@ -304,11 +304,11 @@ asmlinkage void __init mmu_init(void)
 	/* Map in all of RAM starting at CONFIG_KERNEL_START */
 	mapin_ram();
 
-#ifdef HIGHMEM_START_BOOL
-	ioremap_base = HIGHMEM_START;
+#ifdef CONFIG_HIGHMEM_START_BOOL
+	ioremap_base = CONFIG_HIGHMEM_START;
 #else
 	ioremap_base = 0xfe000000UL;	/* for now, could be 0xfffff000 */
-#endif /* CONFIG_HIGHMEM */
+#endif /* CONFIG_HIGHMEM_START_BOOL */
 	ioremap_bot = ioremap_base;
 
 	/* Initialize the context management stuff */
-- 
1.7.4.4




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] [TRIVIAL] microblaze: add missing CONFIG_ prefixes
  2011-10-12 19:28 [PATCH] [TRIVIAL] microblaze: add missing CONFIG_ prefixes Paul Bolle
@ 2011-10-13  8:34 ` Jiri Kosina
  2011-10-13  8:36   ` Michal Simek
  0 siblings, 1 reply; 3+ messages in thread
From: Jiri Kosina @ 2011-10-13  8:34 UTC (permalink / raw)
  To: Paul Bolle; +Cc: linux-kernel, Michal Simek, microblaze-uclinux

On Wed, 12 Oct 2011, Paul Bolle wrote:

> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Entirely untested. Somehow, I don't feel too bad about that. Added the
> maintainer and the mailinglist because this could change the behavior of
> this code.

Yes, this might make so-far unexcercised codepaths to appear, so I'd like 
to have maintainer's Ack before applying it. I don't have microblaze 
cross-compiling setup.

Thanks,

> 
>  arch/microblaze/mm/init.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/microblaze/mm/init.c b/arch/microblaze/mm/init.c
> index 213f2d6..36a133e 100644
> --- a/arch/microblaze/mm/init.c
> +++ b/arch/microblaze/mm/init.c
> @@ -304,11 +304,11 @@ asmlinkage void __init mmu_init(void)
>  	/* Map in all of RAM starting at CONFIG_KERNEL_START */
>  	mapin_ram();
>  
> -#ifdef HIGHMEM_START_BOOL
> -	ioremap_base = HIGHMEM_START;
> +#ifdef CONFIG_HIGHMEM_START_BOOL
> +	ioremap_base = CONFIG_HIGHMEM_START;
>  #else
>  	ioremap_base = 0xfe000000UL;	/* for now, could be 0xfffff000 */
> -#endif /* CONFIG_HIGHMEM */
> +#endif /* CONFIG_HIGHMEM_START_BOOL */
>  	ioremap_bot = ioremap_base;
>  
>  	/* Initialize the context management stuff */
> -- 
> 1.7.4.4
> 
> 
> 

-- 
Jiri Kosina
SUSE Labs

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] [TRIVIAL] microblaze: add missing CONFIG_ prefixes
  2011-10-13  8:34 ` Jiri Kosina
@ 2011-10-13  8:36   ` Michal Simek
  0 siblings, 0 replies; 3+ messages in thread
From: Michal Simek @ 2011-10-13  8:36 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: Paul Bolle, linux-kernel, microblaze-uclinux

Jiri Kosina wrote:
> On Wed, 12 Oct 2011, Paul Bolle wrote:
> 
>> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
>> ---
>> Entirely untested. Somehow, I don't feel too bad about that. Added the
>> maintainer and the mailinglist because this could change the behavior of
>> this code.
> 
> Yes, this might make so-far unexcercised codepaths to appear, so I'd like 
> to have maintainer's Ack before applying it. I don't have microblaze 
> cross-compiling setup.
> 
> Thanks,

Here it is:
Acked-by: Michal Simek <monstr@monstr.eu>

Michal

-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-10-13  8:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-12 19:28 [PATCH] [TRIVIAL] microblaze: add missing CONFIG_ prefixes Paul Bolle
2011-10-13  8:34 ` Jiri Kosina
2011-10-13  8:36   ` Michal Simek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox