public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Friesen <chris.friesen@genband.com>
To: Markus Rechberger <mrechberger@gmail.com>
Cc: Alan Stern <stern@rowland.harvard.edu>, Greg KH <gregkh@suse.de>,
	USB list <linux-usb@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Patch] Increase USBFS Bulk Transfer size
Date: Thu, 13 Oct 2011 10:01:04 -0600	[thread overview]
Message-ID: <4E970B40.8070808@genband.com> (raw)
In-Reply-To: <CA+O4pC+kRXvGYpnHD7bocuL_t+YWLbChKg8kVAtxmMkd+60+CA@mail.gmail.com>

On 10/13/2011 09:19 AM, Markus Rechberger wrote:
> On Thu, Oct 13, 2011 at 4:58 PM, Alan Stern<stern@rowland.harvard.edu>  wrote:

>> This is very interesting.  There are only two things that could be
>> happening: Either the device sends different data during the two tests,
>> or there's a bug in the kernel.

> Before that I insist that this patch will go into the kernel (I know
> that sounds ridiculous but so far I did everything
> you requested me to do), I clearly pointed out that we even have hardware
> specs which can influence the transfer buffer. The patch does not hurt
> and makes the device work.

That makes no sense.  If there's a bug in the hardware we likely don't 
want to make global changes to work around it--a more targeted fix may 
be more appropriate.

If there is a bug in the kernel, why would we want a bandaid patch that 
just happens to make it work rather than a true fix?

Chris

-- 
Chris Friesen
Software Developer
GENBAND
chris.friesen@genband.com
www.genband.com

  reply	other threads:[~2011-10-13 16:01 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-12 12:36 [Patch] Increase USBFS Bulk Transfer size Markus Rechberger
2011-10-12 12:46 ` Markus Rechberger
2011-10-12 13:48 ` Sergei Shtylyov
2011-10-12 14:17 ` Greg KH
2011-10-12 16:59   ` Markus Rechberger
2011-10-12 20:33     ` Greg KH
2011-10-12 21:48       ` Markus Rechberger
2011-10-12 22:09         ` Markus Rechberger
2011-10-13  4:03           ` Manu Abraham
2011-10-13  4:59             ` Markus Rechberger
2011-10-13  5:46               ` Manu Abraham
2011-10-13  8:37                 ` Markus Rechberger
2011-10-13  9:29                   ` Markus Rechberger
2011-10-16  9:22                     ` James Courtier-Dutton
2011-10-13  9:34                   ` Manu Abraham
2011-10-13  9:39                     ` Markus Rechberger
2011-10-13 14:58           ` Alan Stern
2011-10-13 15:19             ` Markus Rechberger
2011-10-13 16:01               ` Chris Friesen [this message]
2011-10-13 16:12                 ` Markus Rechberger
2011-10-13 16:25                   ` Chris Friesen
2011-10-13 18:27                     ` Markus Rechberger
2011-10-13 20:07                       ` Alan Stern
2011-10-13 20:17                         ` Markus Rechberger
2011-10-13 18:21               ` Alan Stern
2011-10-13 19:05                 ` Alan Cox
2011-10-14 19:21             ` Johannes Stezenbach
2011-10-14 20:19               ` Alan Stern
2011-10-14 22:45                 ` Johannes Stezenbach
2011-10-15 11:45                   ` Markus Rechberger
2011-10-15 17:47                     ` Valdis.Kletnieks
2011-10-15 19:08                     ` Alan Stern
2011-10-15 19:04                   ` Alan Stern
2011-10-16  9:10                     ` Johannes Stezenbach
2011-10-16 14:18                       ` Alan Stern
2011-10-17 18:11                     ` Johannes Stezenbach
2011-10-17 18:22                       ` Alan Stern
     [not found]           ` <CAAMvbhFNTQeuJBgsDB9Y5ODc_b2O0X=oP_3uwRpWUREFS9qufA@mail.gmail.com>
2011-10-14  2:47             ` Markus Rechberger
2011-10-14  3:42               ` Markus Rechberger
2011-10-14  3:48                 ` Markus Rechberger
2011-10-14  5:47                 ` Valdis.Kletnieks
2011-10-14  6:23                   ` Markus Rechberger
2011-10-14  8:51                     ` James Courtier-Dutton
2011-10-14 15:38                       ` Markus Rechberger
2011-10-14 14:05                 ` Alan Stern
2011-10-14 14:33                   ` Greg KH
2011-11-07 18:52                     ` Sarah Sharp
2011-11-07 19:12                       ` Alan Stern
2011-11-07 20:18                         ` Sarah Sharp
2011-11-07 20:37                           ` Brink, Peter
2011-11-07 20:53                           ` Alan Stern
2011-11-07 21:49                             ` Greg KH
2011-11-07 23:07                             ` Sarah Sharp
2011-11-08  1:44                               ` Alan Stern
2011-11-07 19:16                       ` Tim Vlaar
2011-11-07 19:55                         ` Alan Stern
2011-11-07 20:13                           ` Tim Vlaar
2011-10-17 18:38                 ` Alan Stern
2011-10-17 19:07                   ` Markus Rechberger
2011-10-12 18:00   ` Mihai Moldovan
2011-10-12 20:36     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E970B40.8070808@genband.com \
    --to=chris.friesen@genband.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mrechberger@gmail.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox