Re: [Patch V2 2/2] gpio-pca953x: fix gpio_base and add verbosity

Hartmut Knaack
2011-10-13T21:46:28Z

Grant Likely schrieb:
> On Tue, Oct 11, 2011 at 11:45:56AM +0200, Hartmut Knaack wrote:
>> Sorry, I messed up the porting from my work files to clean git repo.
>> This should be right now.
>> Inspired by the gpio-pcf857x driver, this patch will output information
>> about the instantiated gpio-chip, including gpio start and end, chip
>> type and if irq is used.
>>
>> Signed-off-by: Hartmut Knaack <knaack.h@gmx.de>
>> -------------------------------------------------------------
>> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
>> index 0721d85..f1a4fad 100644
>> --- a/drivers/gpio/gpio-pca953x.c
>> +++ b/drivers/gpio/gpio-pca953x.c
>> @@ -687,6 +687,12 @@ static int __devinit pca953x_probe(struct
>> i2c_client *client,
>> if (ret)
>> goto out_failed_irq;
>>
>> + dev_info(&client->dev, "gpios %d..%d added on a %s%s\n",
>> + chip->gpio_chip.base,
>> + chip->gpio_chip.base + chip->gpio_chip.ngpio - 1,
>> + client->name,
>> + client->irq ? " (irq ignored)" : "");
>> +
> dev_dbg() for this I think.
A short look into all other gpio drivers revealed which functions are normally used for that purpose:
pr_info: gpio-xilinx
dev_info: gpio-pcf857x, gpio-nomadik, gpio-janz-ttl, gpio-cs5535, gpio-adp5588
printk: gpio-bt8xx
I took that one from the pcf857x driver, but personally I also think that info is an appropriate verbosity level.
Empowered by Ryan Mallon's comment I thought about removing those functions from gpio driver code and move it to gpiochip_add function. This way reducing redundancy and improving uniformity. It's just 7 drivers + gpiolib, which need to be changed. What do you think?
>> if (pdata && pdata->setup) {
>> ret = pdata->setup(client, chip->gpio_chip.base,
>> chip->gpio_chip.ngpio, pdata->context);
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>