public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Smack: compilation fix
@ 2011-10-14 10:16 Jarkko Sakkinen
  2011-10-14 16:04 ` Casey Schaufler
  0 siblings, 1 reply; 3+ messages in thread
From: Jarkko Sakkinen @ 2011-10-14 10:16 UTC (permalink / raw)
  To: Casey Schaufler; +Cc: linux-kernel, linux-security-module, Jarkko Sakkinen

On some build configurations PER_CLEAR_ON_SETID symbol was not
found when compiling smack_lsm.c. This patch fixes the issue by
explicitly doing #include <linux/personality.h>.

Signed-off-by: Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
---
 security/smack/smack_lsm.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
index d55b991..7db62b4 100644
--- a/security/smack/smack_lsm.c
+++ b/security/smack/smack_lsm.c
@@ -35,6 +35,7 @@
 #include <linux/audit.h>
 #include <linux/magic.h>
 #include <linux/dcache.h>
+#include <linux/personality.h>
 #include "smack.h"
 
 #define task_security(task)	(task_cred_xxx((task), security))
-- 
1.7.5.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Smack: compilation fix
  2011-10-14 10:16 [PATCH] Smack: compilation fix Jarkko Sakkinen
@ 2011-10-14 16:04 ` Casey Schaufler
  2011-10-15  0:40   ` James Morris
  0 siblings, 1 reply; 3+ messages in thread
From: Casey Schaufler @ 2011-10-14 16:04 UTC (permalink / raw)
  To: Jarkko Sakkinen, James Morris
  Cc: linux-kernel, linux-security-module, Casey Schaufler

On 10/14/2011 3:16 AM, Jarkko Sakkinen wrote:
> On some build configurations PER_CLEAR_ON_SETID symbol was not
> found when compiling smack_lsm.c. This patch fixes the issue by
> explicitly doing #include <linux/personality.h>.
>
> Signed-off-by: Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>

Applied to git://gitorious.org/smack-next/kernel.git#master

James, can you pull for security testing please?

commit 16014d87509e26d6ed6935adbbf437a571fb5870

> ---
>  security/smack/smack_lsm.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> index d55b991..7db62b4 100644
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -35,6 +35,7 @@
>  #include <linux/audit.h>
>  #include <linux/magic.h>
>  #include <linux/dcache.h>
> +#include <linux/personality.h>
>  #include "smack.h"
>  
>  #define task_security(task)	(task_cred_xxx((task), security))


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Smack: compilation fix
  2011-10-14 16:04 ` Casey Schaufler
@ 2011-10-15  0:40   ` James Morris
  0 siblings, 0 replies; 3+ messages in thread
From: James Morris @ 2011-10-15  0:40 UTC (permalink / raw)
  To: Casey Schaufler; +Cc: Jarkko Sakkinen, linux-kernel, linux-security-module

On Fri, 14 Oct 2011, Casey Schaufler wrote:

> On 10/14/2011 3:16 AM, Jarkko Sakkinen wrote:
> > On some build configurations PER_CLEAR_ON_SETID symbol was not
> > found when compiling smack_lsm.c. This patch fixes the issue by
> > explicitly doing #include <linux/personality.h>.
> >
> > Signed-off-by: Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
> 
> Applied to git://gitorious.org/smack-next/kernel.git#master
> 
> James, can you pull for security testing please?

Pulled.

> 
> commit 16014d87509e26d6ed6935adbbf437a571fb5870
> 
> > ---
> >  security/smack/smack_lsm.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> > index d55b991..7db62b4 100644
> > --- a/security/smack/smack_lsm.c
> > +++ b/security/smack/smack_lsm.c
> > @@ -35,6 +35,7 @@
> >  #include <linux/audit.h>
> >  #include <linux/magic.h>
> >  #include <linux/dcache.h>
> > +#include <linux/personality.h>
> >  #include "smack.h"
> >  
> >  #define task_security(task)	(task_cred_xxx((task), security))
> 

-- 
James Morris
<jmorris@namei.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-10-15  0:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-14 10:16 [PATCH] Smack: compilation fix Jarkko Sakkinen
2011-10-14 16:04 ` Casey Schaufler
2011-10-15  0:40   ` James Morris

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox