From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] video: platinumfb: Add __devexit_p at necessary place
Date: Sun, 16 Oct 2011 21:34:13 +0000 [thread overview]
Message-ID: <4E9B4DD5.8050108@gmx.de> (raw)
In-Reply-To: <1317801698.12133.1.camel@phoenix>
On 10/05/2011 08:01 AM, Axel Lin wrote:
> According to the comments in include/linux/init.h:
>
> "Pointers to __devexit functions must use __devexit_p(function_name), the
> wrapper will insert either the function_name or NULL, depending on the config
> options."
>
> We have __devexit annotation for platinumfb_remove(), thus add __devexit_p at
> necessary place.
Applied.
Thanks,
Florian Tobias Schandinat
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/video/platinumfb.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/platinumfb.c b/drivers/video/platinumfb.c
> index 6694923..ae3caa6 100644
> --- a/drivers/video/platinumfb.c
> +++ b/drivers/video/platinumfb.c
> @@ -683,7 +683,7 @@ static struct platform_driver platinum_driver =
> .of_match_table = platinumfb_match,
> },
> .probe = platinumfb_probe,
> - .remove = platinumfb_remove,
> + .remove = __devexit_p(platinumfb_remove),
> };
>
> static int __init platinumfb_init(void)
prev parent reply other threads:[~2011-10-16 21:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-05 8:01 [PATCH] video: platinumfb: Add __devexit_p at necessary place Axel Lin
2011-10-16 21:34 ` Florian Tobias Schandinat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E9B4DD5.8050108@gmx.de \
--to=florianschandinat@gmx.de \
--cc=axel.lin@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox