From: John Hughes <john@calvaedi.com>
To: Valdis.Kletnieks@vt.edu
Cc: John Hughes <john@Calva.COM>,
linux-kernel@vger.kernel.org, Mattia Dongili <malattia@linux.it>,
Stelian Pop <stelian@popies.net>
Subject: Re: sony-laptop driver: Volume keys on Sony Vaio TX3 don't work
Date: Mon, 17 Oct 2011 01:13:21 +0200 [thread overview]
Message-ID: <4E9B6511.4060107@calvaedi.com> (raw)
In-Reply-To: <74494.1318789218@turing-police.cc.vt.edu>
On 10/16/2011 08:20 PM, Valdis.Kletnieks@vt.edu wrote:
> On Sun, 16 Oct 2011 19:45:14 +0200, John Hughes said:
>
>
>> Here's a patch that makes the volume keys work for me. Tested on
>> current git
>>
> Do we know if this is applicable to all Sony laptops, or only a few
> busticated
> models?
>
>
>
The current code is simply wrong. It might work by accident on some
models, but.,..
(Why wrong? it says event (0x01,0x05) is PROG1, but event (0x01, 0x05)
is Volume up, Make up your mind please. PS it's volume DOWN not up).
Wouldn't it be easier just to leave the decision for user mode? Make
the different events generate different "scancodes" and let udev sort
them out?
prev parent reply other threads:[~2011-10-16 23:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-16 11:11 sony-laptop driver: Volume keys on Sony Vaio TX3 don't work John Hughes
2011-10-16 12:30 ` Bug: changing keycodes generated by sony-laptop doesn't work John Hughes
2011-10-16 13:30 ` John Hughes
2011-10-17 9:08 ` John Hughes
2011-10-16 13:27 ` sony-laptop driver: Volume keys on Sony Vaio TX3 don't work John Hughes
2011-10-16 17:45 ` John Hughes
2011-10-16 18:20 ` Valdis.Kletnieks
2011-10-16 21:38 ` Mattia Dongili
2011-10-16 21:50 ` Valdis.Kletnieks
2011-10-16 23:17 ` John Hughes
2011-10-17 21:43 ` Mattia Dongili
2011-10-18 9:02 ` John Hughes
2011-10-17 21:45 ` Mattia Dongili
2011-10-18 9:07 ` John Hughes
2011-10-19 22:01 ` John Hughes
2011-10-16 23:13 ` John Hughes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E9B6511.4060107@calvaedi.com \
--to=john@calvaedi.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=john@Calva.COM \
--cc=linux-kernel@vger.kernel.org \
--cc=malattia@linux.it \
--cc=stelian@popies.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox